Skip to content

UR-4513 Fix - Notice design compatibility with WP 7.0#1283

Open
MILAN88888 wants to merge 1 commit into
masterfrom
UR-4513-fix/notice-design-compatibility-with-7-0
Open

UR-4513 Fix - Notice design compatibility with WP 7.0#1283
MILAN88888 wants to merge 1 commit into
masterfrom
UR-4513-fix/notice-design-compatibility-with-7-0

Conversation

@MILAN88888
Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

Screenshot from 2026-05-21 10-19-58

How to test the changes in this Pull Request:

  1. Verify the design

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification of the currently available functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?
  • Have you updated the documentation accordingly?

Changelog entry

UR-4513 Fix - Notice design compatibility with WP 7.0

…notice-dismiss

- Fix get_single_valid_notice() to handle conditions_to_display => true, bypassing
  condition checks for notices that should always display for admins
- Use isset() fallback for reopen_days/reopen_times to prevent undefined index errors
- Replace WP core notice-dismiss/notice-dismiss-permanently/notice-dismiss-temporarily
  classes with ur-notice-dismiss/* to prevent WordPress admin CSS from stripping
  button borders and backgrounds (position:absolute, border:none, background:none)
- Fix broken selector in ur-notice.css and add vertical-align/line-height to smile icon
- Fix ur_repeater_fields_template_overriden_notice() returning  instead
  of merged , which silently discarded all other custom notices
@MILAN88888 MILAN88888 requested a review from joshianup1 May 21, 2026 06:55
@MILAN88888 MILAN88888 self-assigned this May 21, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security Check

✅ No security issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant