-
Notifications
You must be signed in to change notification settings - Fork 17
chore: add WordPress 6.9 to test matrix #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add WordPress 6.9 to the CI test matrix - Exclude PHP 7.4 from WordPress 6.9 tests (per existing pattern) - Update nightly workflow to use WordPress 6.9 as base - Update .env.dist default to WordPress 6.9 Closes #397
🦋 Changeset detectedLatest commit: 4b90611 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Reduce test matrix to WordPress 6.9 and 6.8 only - Test against PHP 8.3, 8.2, and 8.1 - Update nightly workflow to use WordPress 6.9 as base - Update .env.dist default to WordPress 6.9 Closes #397
…m/wpengine/wp-graphql-content-blocks into chore/wordpress-6.9-compatibility
- Reduce test matrix to WordPress 6.9 and 6.8 only - Test against PHP 8.3, 8.2, and 8.1 - Update nightly workflow to use WordPress 6.9 as base - Update .env.dist default to WordPress 6.9 Closes #397
…m/wpengine/wp-graphql-content-blocks into chore/wordpress-6.9-compatibility
- Reduce test matrix to WordPress 6.9 and 6.8 only - Test against PHP 8.3, 8.2, and 8.1 - Update nightly workflow to use WordPress 6.9 as base - Update .env.dist default to WordPress 6.9 - Fix MySQL SSL option syntax (--ssl-mode=DISABLED) Closes #397
…m/wpengine/wp-graphql-content-blocks into chore/wordpress-6.9-compatibility
The --ssl-mode=DISABLED option doesn't work in GitHub Actions. Community-standard fix: don't specify SSL options at all - MySQL defaults work for local test connections.
Creates wordpress_unit_test database on MySQL container startup. This ensures the test database exists before PHPUnit runs.
WordPress 6.9 introduces expected schema changes (new blocks, changed field types, removed templates). The schema inspector should report these changes for release notes, but not block CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the CI test matrix to add support for WordPress 6.9 and modernizes the PHP version support. The changes align the testing infrastructure with WordPress 6.9's requirements while removing outdated version combinations.
Key Changes:
- Updated test matrix to test WordPress 6.9 and 6.8 with PHP 8.3, 8.2, and 8.1
- Updated default WordPress version from 6.2 to 6.9 in environment configuration
- Added SQL script for test database creation
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/test-plugin.yml |
Simplified test matrix to WordPress 6.9/6.8 with PHP 8.3/8.2/8.1, removing older versions and exclusion rules |
.github/workflows/test-plugin-nightly.yml |
Updated base WordPress version from 6.8 to 6.9 for nightly builds |
.github/workflows/schema-linter.yml |
Added continue-on-error: true to Schema Inspector step |
.env.dist |
Updated default WordPress version from 6.2 to 6.9 |
.docker/mysql/00-create-test-db.sql |
Added new SQL script to create test database with appropriate permissions |
.changeset/wordpress-69-compatibility.md |
Added changeset documenting WordPress 6.9 compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
(@josephfusco beyond the scope of this PR, but take a glance at wp-graphql/wp-graphql#3446 that replaces the custom docker + plugin ci/cd with |
Bump the default PHP version from 8.0 to 8.1 for local development and testing environments.
Introduces a 'wp-version' input to the setup-wordpress composite action, allowing the WordPress version to be specified (defaulting to 6.8). Updates the schema-linter workflow to use this input, improving flexibility for WordPress version management in CI.
Bump the WordPress version in the setup step from 6.8 to 6.9. Add comments and set 'continue-on-error: true' for the schema inspector step to ensure schema changes do not block CI, as they are expected between WordPress versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #397