Skip to content

ensure clean imagify state before tagged smoke scenarios #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mai-Saad merged 4 commits into from
Apr 28, 2026
Merged

ensure clean imagify state before tagged smoke scenarios #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fe9cd5
ensure clean imagify state before tagged smoke scenarios
hanna-meda Apr 16, 2026
8bc813e
remove redundant Imagify install check before uninstall
hanna-meda Apr 16, 2026
21108f8
remove smoke tag from the hook expression
hanna-meda Apr 16, 2026
c9b1f0d
update comment
hanna-meda Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/features/broken-links.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@setup @smoke @brokenlinks
@setup @smoke @brokenlinks @requires-clean-imagify
Feature: Broken links in WP Rocket settings UI

Scenario: WP Rocket settings links are not broken
Expand Down
1 change: 1 addition & 0 deletions src/features/delete-plugin.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Feature: C4466 - Should successfully delete the plugin
Then plugin should delete successfully
But I must not see any error in debug.log

@requires-clean-imagify
Scenario: WP Rocket is installed and activated
Given plugin is installed 'new_release'
And plugin is activated
Expand Down
2 changes: 1 addition & 1 deletion src/features/enable-all-features.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@smoke @local @setup
@smoke @local @setup @requires-clean-imagify
Feature: C1205 - Enabling all WP Rocket features should not throw any fatal errors

Background:
Expand Down
2 changes: 1 addition & 1 deletion src/features/roll-back.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@smoke @local @setup
@smoke @local @setup @requires-clean-imagify
Feature: C11856 - Should roll back to the last previous major version when using the roll back functionality

Background:
Expand Down
2 changes: 1 addition & 1 deletion src/features/self-host-google-fonts.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@smoke @selfhostgooglefonts @setup
@smoke @selfhostgooglefonts @setup @requires-clean-imagify

Feature: Google Fonts are self-hosted

Expand Down
2 changes: 2 additions & 0 deletions src/features/settings-export-import.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Feature: C2148 - Should not change the content of existing fields
Background:
Given I am logged in

@requires-clean-imagify
Scenario: Data imported correctly
Given plugin is installed 'previous_stable'
And plugin is activated
Expand Down Expand Up @@ -39,6 +40,7 @@ Feature: C2148 - Should not change the content of existing fields
And I am logged in
Then I must not see any error in debug.log

@requires-clean-imagify
Scenario: Should not change enabled fields with update
Given plugin is installed 'previous_stable'
And plugin is activated
Expand Down
8 changes: 8 additions & 0 deletions src/support/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,14 @@ BeforeAll(async function (this: ICustomWorld) {
}
});

/**
* Before each scenario tagged with @requires-clean-imagify, except those also tagged with
* @imagify-compatibility, ensures Imagify is not installed.
*/
Before({ tags: '@requires-clean-imagify and not @imagify-compatibility' }, async function (this: ICustomWorld): Promise<void> {
Copy link
Copy Markdown
Contributor

@Mai-Saad Mai-Saad Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we need this run before smoke test , why not just use @smoke instead of @requires-clean-imagify?

Copy link
Copy Markdown
Contributor Author

@hanna-meda hanna-meda Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mai-Saad, I used requires-clean-imagify so this hook can be reused beyond smoke. It is currently applied only in smoke, but the precondition itself is not smoke-specific.

await uninstallPlugin('imagify');
});

/**
* Before each test scenario without the @setup tag, performs setup tasks.
*/
Expand Down
Loading