Skip to content

Fix #7417: Fix exclusions logic #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wordpressfan merged 2 commits into from
Aug 15, 2025
Merged

Fix #7417: Fix exclusions logic #64

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14963c6
Fix exclusions logic
Miraeld Aug 1, 2025
9caa32b
Add URL exclusion logic for external font processing and correspondin…
Miraeld Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/BeaconPreloadFonts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,10 @@ class BeaconPreloadFonts {
}

// Check exclusions instead of allowlist
const exclusions = this.config.external_font_exclusions || [];
return !exclusions.some(exclusion => link.href.includes(exclusion));
const preloadFontsExclusions = this.config.preload_fonts_exclusions || [];
const externalFontExclusions = this.config.external_font_exclusions || [];
const allExclusions = [...preloadFontsExclusions, ...externalFontExclusions];
return !allExclusions.some((exclusion) => link.href.includes(exclusion));
Comment thread
Miraeld marked this conversation as resolved.
Outdated
} catch (e) {
return false;
}
Expand Down