Enhancement/11 move vat rates by mostafa-hisham · Pull Request #12 · wp-media/pyvat

mostafa-hisham · 2025-12-11T08:12:28Z

Description

Fixes #11

Type of change

New feature (non-breaking change which adds functionality).
Bug fix (non-breaking change which fixes an issue).
Enhancement (non-breaking change which improves an existing functionality).
Breaking change (fix or feature that would cause existing functionality to not work as before).
Sub-task of #(issue number)
Chore
Release

Detailed scenario

What was tested

unit tests

How to test

ci i should run unit test
follow readme and run tests

Technical description

Documentation

no

New dependencies

no

Risks

no

Mandatory Checklist

Code validation

I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
I triggered all changed lines of code at least once without new errors/warnings/notices.
I implemented built-in tests to cover the new/changed code.

Code style

I wrote a self-explanatory code about what it does.
I protected entry points against unexpected inputs.
I did not introduce unnecessary complexity.
Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

Additional Checks

In the case of complex code, I wrote comments to explain it.
When possible, I prepared ways to observe the implemented system (logs, data, etc.).
I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

…without VAT_NUMBER_EXPRESSIONS

nicomollet · 2025-12-11T09:51:10Z

    'EG': EgVatRules(),
+    'CH': ChVatRules(),
+    'CA': CaVatRules(),
+    'NO': NoVatRules(),


I am not confortable with the NoVat naming.
Can we name the rules with the countries explicitely named: Norway, Canada, FranceDom, Egypt, Switzerland?

@mostafa-hisham Please rename the shortnames to country:

CaVatRules > CanadaVatRues

NoVatRules > NorwayVatRules

So that we can avoid the misleading NoVatRules

nicomollet · 2025-12-11T09:57:25Z

@mostafa-hisham

Monaco and 3 Doms can be considered differently.
Monaco is exactly like France, so it can be added added to the EuropeVAT rules and have same rules as France 20%.

But the 3 Doms are not Europe VAT zone (and have different VAT rates).

nicomollet · 2025-12-11T16:37:56Z

+        # French VAT zone: seller in France/territories selling to buyer in France/territories
+        # For B2B or consumers after 2015-01-01, charge buyer's country VAT
+        if seller_in_french_zone and buyer_in_french_zone:
+            if buyer.is_business or date >= JANUARY_1_2015:


I think we can remove this 2015 condition everywhere

nicomollet

Check comments:

code consistency
behavior of B2B exemptions for NON EU

nicomollet · 2025-12-11T16:39:29Z

    'EG': EgVatRules(),
+    'CH': ChVatRules(),
+    'CA': CaVatRules(),
+    'NO': NoVatRules(),


@mostafa-hisham Please rename the shortnames to country:

CaVatRules > CanadaVatRues

NoVatRules > NorwayVatRules

So that we can avoid the misleading NoVatRules

mostafa-hisham · 2025-12-15T07:19:25Z

@nicomollet if we are ok with this PR we should release it

nicomollet

Approving @mostafa-hisham

nicomollet · 2025-12-15T14:14:43Z

@mostafa-hisham Please check this message from Mathieu:

Egypt: VAT (14%) must be applied to both B2C & B2B sales

https://group-onecom.slack.com/archives/C08EFCVF459/p1765807325784649

This issue will be closed:

https://github.com/wp-media/monies/issues/179#

…ITAL_GOODS.md

…yvat into enhancement/11-move-vat-rates

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-15T16:20:28Z

+        ItemType.generic_physical_good: Decimal(25.5),
+        ItemType.generic_electronic_service: Decimal(25.5),
+        ItemType.generic_telecommunications_service: Decimal(25.5),
+        ItemType.generic_broadcasting_service: Decimal(25.5),
+        ItemType.prepaid_broadcasting_service: Decimal(25.5),
        ItemType.ebook: Decimal(10),
-        ItemType.enewspaper: Decimal(24),
+        ItemType.enewspaper: Decimal(25.5),


VAT rate update for Finland. The test expectations show Finland's VAT rate increasing from 24% to 25.5%, which is reflected in the updated test on lines 100-106. However, ensure this VAT rate change (from 24% to 25.5%) is accurate and matches official Finnish tax authority announcements. The comment in vat_rules.py indicates "VAT rates updated July 1st 2025", so verify this is the correct effective date for Finland's rate change.

@nicomollet, are we good with this?

Let's ignore this type of product

Co-authored-by: Copilot <[email protected]>

nicomollet

Approved @mostafa-hisham

mostafa-hisham · 2025-12-17T05:59:38Z

QA on monies staging ✅

https://github.com/wp-media/monies/pull/230#issue-3733560193

mostafa-hisham added 10 commits December 11, 2025 07:56

remove egypt from eu countries list

3d1e48d

add new countries registries

f45ef1d

init new registries and Skip vat_num format validation for countries …

8b3adc7

…without VAT_NUMBER_EXPRESSIONS

add vat_rules for new countries

9696462

add test for new countries

1cb9f87

refactor old tests to work with our edits

0dcd614

update readme

12ad19a

add tests ci

ca9ce85

workflow on forks

d631d34

fix workflow branch

7df0c08

nicomollet reviewed Dec 11, 2025

View reviewed changes

Comment thread pyvat/__init__.py

mostafa-hisham added 3 commits December 11, 2025 13:34

chnage class name

c9d6052

Norway B2B not exempt

106b503

treat monaco and france regions like france but with different vat rates

900a182

nicomollet reviewed Dec 11, 2025

View reviewed changes

Comment thread pyvat/vat_rules.py Outdated

nicomollet requested changes Dec 11, 2025

View reviewed changes

mostafa-hisham added 5 commits December 12, 2025 08:55

rename classses

662a6a7

add regex to Frech countries

95f3550

create and use global FRANCE_COUNTRY_CODES

acb0fdb

create and use NON_EU_COUNTRY_CODES

aa85a94

add new test that checks VAT% for noneu countries

81e7ba7

mostafa-hisham requested a review from nicomollet December 12, 2025 09:48

fix date condition

2cd45ca

nicomollet reviewed Dec 12, 2025

View reviewed changes

Comment thread pyvat/vat_rules.py Outdated

mostafa-hisham added 2 commits December 12, 2025 13:06

simplfiy conditon

3718f20

codition explaination

370809d

nicomollet reviewed Dec 12, 2025

View reviewed changes

Comment thread pyvat/vat_rules.py Outdated

mostafa-hisham added 5 commits December 12, 2025 14:04

fix codition

26c8bd5

update readme

1cdf199

remove line

9d2431b

fix imports, workflow and typo

4601aa6

fix confilect

6f53399

mostafa-hisham requested a review from nicomollet December 12, 2025 12:18

nicomollet approved these changes Dec 15, 2025

View reviewed changes

mostafa-hisham added 2 commits December 15, 2025 16:10

Franc monaco and dom

084ced6

Fix test

4035704

mostafa-hisham and others added 5 commits December 15, 2025 16:25

create doc with vat rates for frnace as seller of digital goods

6aadd1a

Rename FRANCE_VAT_RATES_DIGITAL_GOODS.md to docs/FRANCE_VAT_RATES_DIG…

edcc349

…ITAL_GOODS.md

handle Great Britain

bae70a3

Merge branch 'enhancement/11-move-vat-rates' of github.com:wp-media/p…

528f133

…yvat into enhancement/11-move-vat-rates

EG 14 b2b/b2c and add FR test

5373fd5

mostafa-hisham requested a review from Copilot December 15, 2025 15:27

Copilot started reviewing on behalf of mostafa-hisham December 15, 2025 16:08 View session

Copilot AI reviewed Dec 15, 2025

View reviewed changes

mostafa-hisham and others added 5 commits December 15, 2025 18:30

Update tests/test_new_countries.py

682258f

Co-authored-by: Copilot <[email protected]>

Update tests/test_new_countries.py

7013fda

Co-authored-by: Copilot <[email protected]>

Update tests/test_validators.py

5f7f3bd

Co-authored-by: Copilot <[email protected]>

Update README.rst

3fb7220

Co-authored-by: Copilot <[email protected]>

Update tests/test_new_countries.py

bf3947a

Co-authored-by: Copilot <[email protected]>

mostafa-hisham requested a review from nicomollet December 15, 2025 16:33

nicomollet approved these changes Dec 16, 2025

View reviewed changes

EG b2b 0 vat rate

eef3a89

nicomollet approved these changes Dec 17, 2025

View reviewed changes

mostafa-hisham merged commit 51e59f8 into master Dec 19, 2025
1 check passed

Conversation

mostafa-hisham commented Dec 11, 2025

Description

Type of change

Detailed scenario

What was tested

How to test

Technical description

Documentation

New dependencies

Risks

Mandatory Checklist

Code validation

Code style

Unticked items justification

Additional Checks

Uh oh!

nicomollet Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

nicomollet Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicomollet commented Dec 11, 2025

Uh oh!

nicomollet Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicomollet left a comment

Choose a reason for hiding this comment

Uh oh!

nicomollet Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mostafa-hisham commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicomollet left a comment

Choose a reason for hiding this comment

Uh oh!

nicomollet commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

mostafa-hisham Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicomollet Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicomollet left a comment

Choose a reason for hiding this comment

Uh oh!

mostafa-hisham commented Dec 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

mostafa-hisham commented Dec 15, 2025 •

edited

Loading

nicomollet commented Dec 15, 2025 •

edited

Loading

mostafa-hisham Dec 15, 2025 •

edited

Loading