FIX: Removes partners.one-specific tracking methods to make the library generic#5
Merged
johngathure merged 4 commits intowp-media:trunkfrom Jan 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #605
The library previously included convenience methods (
track_order_placed,track_sso_link_clicked,track_actionable_resolved) that are specific to partners.one's use case. These methods have been removed to keep the library generic and usable by anyone. Users can still achieve the same functionality by using the generictrack()method directly.Type of change
Detailed scenario
What was tested
track(),set_user_property(),set_user_properties(),hash()) still work correctlyHow to test
Verify that removed methods (track_order_placed, track_sso_link_clicked, track_actionable_resolved) are no longer available
Affected Features & Quality Assurance Scope
Removed methods: track_order_placed(), track_sso_link_clicked(), track_actionable_resolved()
Technical description
Documentation
This change removes partners.one-specific convenience methods from the Tracking class. The library now only provides generic tracking functionality
New dependencies
None
Risks
None
Mandatory Checklist
Code validation
Code style
Unticked items justification
None
Additional Checks