Skip to content

Add Backwpup Start Jobs with Links plugin to enable job initiation via links#1

Open
Honemo wants to merge 2 commits intomainfrom
feature/738-add-a-filter-to-enable-secure-external-backup-links
Open

Add Backwpup Start Jobs with Links plugin to enable job initiation via links#1
Honemo wants to merge 2 commits intomainfrom
feature/738-add-a-filter-to-enable-secure-external-backup-links

Conversation

@Honemo
Copy link
Copy Markdown
Collaborator

@Honemo Honemo commented Apr 14, 2025

Description

Allows users to activate external/secure links to launch a backup with a filter

Type of change

  • New feature (non-breaking change which adds functionality).

Detailed scenario

What was tested

Describe the scenarios that you tested, and specify if it is automated or manual. For manual scenarios, provide a screenshot of the results.

How to test

Describe how the PR can be tested so that the validator can be autonomous: environment, dependencies, specific setup, steps to perform, API requests, etc.

Technical description

Documentation

Explain how this code works. Diagrams & drawings are welcome.

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

Copy link
Copy Markdown

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change.
Thanks @Honemo

function allow_start_with_links( $content ) {
return true;
}
add_filter( 'backwpup_allow_job_start_with_links', __NAMESPACE__ . '\allow_start_with_links' ); No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
add_filter( 'backwpup_allow_job_start_with_links', __NAMESPACE__ . '\allow_start_with_links' );
add_filter( 'backwpup_allow_job_start_with_links', '__return_true' );

Comment on lines +19 to +21
function allow_start_with_links( $content ) {
return true;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants