Skip to content

Update group one ips.#148

Merged
johngathure merged 15 commits intomasterfrom
develop
Dec 18, 2025
Merged

Update group one ips.#148
johngathure merged 15 commits intomasterfrom
develop

Conversation

@johngathure
Copy link
Copy Markdown

@johngathure johngathure commented Dec 18, 2025 •
edited
Loading

Description

More information #147

Fixes #(issue number)
Explain how this code impacts users.

Type of change

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Enhancement (non-breaking change which improves an existing functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as before).
  • Sub-task of #(issue number)
  • Chore
  • Release

Detailed scenario

What was tested

Describe the scenarios that you tested, and specify if it is automated or manual. For manual scenarios, provide a screenshot of the results.

How to test

Describe how the PR can be tested so that the validator can be autonomous: environment, dependencies, specific setup, steps to perform, API requests, etc.

Affected Features & Quality Assurance Scope

Please specify which existing features or modules are impacted by the changes in this Pull Request. This information is crucial for the QA team to properly define the testing scope and ensure comprehensive test coverage.

Technical description

Documentation

Explain how this code works. Diagrams & drawings are welcome.

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.
  • Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

If some mandatory items are not relevant, explain why in this section.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.
  • When possible, I prepared ways to observe the implemented system (logs, data, etc.).
  • I added error handling logic when using functions that could throw errors (HTTP/API request, filesystem, etc.)

johngathure and others added 15 commits December 17, 2025 10:50
@johngathure
Changes IP ranges to individual IP addresses for group.one infrastruc…
2d3f763 
…ture
@johngathure
ignore line too long pylint error.
71bae18
@johngathure
store the list of ips in a list, then convert it to a string for
ce660c3 
readiblity and maintainability.
@johngathure
add templates for creating a pull requests and grooming.
e8cb70c
@johngathure
docker compose file to easily start the app locally.
d26356f
@johngathure @claude
Add comprehensive unit tests for ServerListHandler
f7b4970 
Implements test coverage for IP listing functionality including:
- CloudFlare IPv4/IPv6 retrieval with error handling
- Group.One IPv4/IPv6 address validation
- WP Rocket IP generation (human-readable and machine-readable)
- Slack integration testing
- Validates change from CIDR ranges to individual IPs

All 12 tests passing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@johngathure
fix pylint issues.
093b820
@johngathure
update docstrings.
402c3d7
@johngathure
end the list of ips with a new line.
3ad8aed
@johngathure
fix failing tests.
0e9c85b
@johngathure
apply copilot changes.
b31ab4e
@johngathure
add pull request template.
8280c85
@johngathure
add documentation.
260bf49
@johngathure @claude
Fix markdown rendering by removing control characters
8648d7a 
Removed non-printable control characters (null bytes and file separators) from endpoints.md that were preventing GitHub from rendering it as markdown. File now recognized as ASCII text.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@johngathure
Merge pull request #147 from wp-media/update-ips
cddd8af 
Update group.one IPv4 addresses to specific IPs
@johngathure johngathure requested a review from a team December 18, 2025 06:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 18, 2025

Diff Coverage

Diff: origin/master...HEAD, staged and unstaged changes

  • sources/handlers/ServerListHandler.py (100%)
  • tests/unit/ServerListHandlerTest.py (100%)

Summary

  • Total: 327 lines
  • Missing: 0 lines
  • Coverage: 100%

@johngathure johngathure merged commit 1669759 into master Dec 18, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mostafa-hisham mostafa-hisham mostafa-hisham approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johngathure @mostafa-hisham