node: Governor token list update #4253
Conversation
djb15
commented
Feb 1, 2025
•
djb15
commented
StablecoinsThe chain 16 stablecoin is one that we already know isn't properly captured by CoinGecko but I checked on the prices of the other tokens marked as stablecoins. Synthetic USDThis token appears to be archived according to CoinGecko. https://www.coingecko.com/en/coins/synthetic-usd Coin98I can't find any reference to Coin98 being a stablecoin so I think the 'stablecoin depeg' notice here is a false positive. We should probably add it to the allow-list in the script. https://www.coingecko.com/en/coins/coin98-dollar |
|
To make our lives easier, it would be nice if this script also generated a URL to the CoinGecko page based on the CoinGecko ID, if it exists. |
|
I think CUSD is supposed to be a stablecoin: https://docs.coin98.com/audits/coin98-dollar. Also if you look back far enough it was previously pegged to $1. I'd rather keep it around for now and we can reassess if it becomes a regular occurrence?
Great suggestion! I can't believe I never realised that the CoinGecko id is the URL slug 🤦♂️ |
djb15
force-pushed
the
node/governor-token-list-update
branch
from
f66837f to
6b6519d
Compare
| @@ -274,7 +276,7 @@ axios | |||
|
|
|||
| // We add in the "=" character to ensure an undefined symbol | |||
| // does not mess up the removed tokens logic | |||
| newTokenKeys[chain + "-" + wormholeAddr] = "=" + data.Symbol; | |||
| newTokenKeys[chain + "-" + wormholeAddr] = ["=" + data.Symbol, data.CoinGeckoId]; | |||
There was a problem hiding this comment.
If data.Symbol is undefined, is this line going to hide that? It might make it look like data.CoinGeckId is the symbol.
It might be worth replacing data.Symbol with a string like UNDEFINED manually if it doesn't exist rather than use an empty string (which I assume is what happens now)
There was a problem hiding this comment.
I might be misunderstanding but I don't think this is true? The symbol logic is identical to before, I've just changed the mapping from string=>string to string=>[string, string]. And I index into the array with the changes below
There was a problem hiding this comment.
There are a few entries above that look like this:
{
"token": "1-05beb884b642b260d9c2b53cb3d876b8b4de72aea0d787d779bf4266688a3935-",
"previousPrice": 14.81,
"newPrice": 0.00451702,
"percentageChange": "-100.0"
},
Where the token has no Symbol and just ends with -. I think in this case we just know, "ah, there's no symbol." With these new changes, if there is only the Symbol and no CG ID (or vice-versa) this output could get a little harder to parse.
Anyway it's a small detail so we can drop it here and maybe pick it up another time.
There was a problem hiding this comment.
No symbol is a valid case for SPL tokens, not sure if that's still true for new tokens, but at least historically that was possible which is why we have those. Re CoinGecko ID, I think we're guaranteed to have that because otherwise we wouldn't have the data being returned from the API in the first place. Plus here's an example of how it would render:
{
"token": "1-067d3988ce882945c63a0717a92538addd9a37550ce5cd711f76ca74a4c89786-",
"previousPrice": 0.00016403,
"newPrice": 0.00010722,
"percentageChange": "-34.6",
"url": "https://www.coingecko.com/en/coins/solcial"
},
There was a problem hiding this comment.
OK cool, thanks for walking me through that
|
Left a comment about the script modifications. Keeping CUSD as-is sounds good to me |
