Do not render widget when no token config found #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for wormhole-connect pending review.Visit the deploys page to approve it
|
👷 Deploy request for wormhole-connect-mainnet pending review.Visit the deploys page to approve it
|
emreboga
force-pushed
the
emre/widget-check-tokenconfig
branch
4 times, most recently
from
889be5b to
8e90bf6
Compare
emreboga
commented
Dec 10, 2024
wormhole-connect/src/views/v2/Bridge/ReviewTransaction/GasSlider.tsx
Outdated
Show resolved
Hide resolved
emreboga
force-pushed
the
emre/widget-check-tokenconfig
branch
from
8e90bf6 to
05be131
Compare
emreboga
force-pushed
the
emre/widget-check-tokenconfig
branch
from
05be131 to
80a8247
Compare
artursapek
requested changes
Feb 5, 2025
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
emreboga
force-pushed
the
emre/widget-check-tokenconfig
branch
from
80a8247 to
e84f5c3
Compare
Signed-off-by: Emre Bogazliyanlioglu <[email protected]>
emreboga
force-pushed
the
emre/widget-check-tokenconfig
branch
from
e84f5c3 to
bb0394d
Compare
artursapek
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very unlikely case unless a user tempers with the localStorage entry. It was discovered while testing Portal with an invalid localStorage entry. To fix this potential problem we are adding another layer of verification to filter out the entries with no token configs.