(chore): change browser example to query from the CDN drop in by default#292
Merged
Conversation
kchaw2005
requested review from
Gr1dlock,
Guardiola31337,
SeanROlszewski,
Takaros999,
andy-t-wang,
chipp,
murph and
paolodamico
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Takaros999
approved these changes
Jun 24, 2026
| <script src="https://unpkg.com/@worldcoin/idkit-core@4.2.0"></script> | ||
| <script> | ||
| const CDN_IDKIT_SCRIPT_URL = | ||
| "https://unpkg.com/@worldcoin/idkit-core@4.2.0"; |
Contributor
There was a problem hiding this comment.
maybe remove the version so it always pulls in the latest one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
nextjs/ examples want to pull IDKit components from the live package and browser/ examples want to use the CDN-released url as a drop in.
Fix
made its so example in browser only uses
<script src="https://unpkg.com/@worldcoin/idkit-core@4.2.0"></script>for its request builderNote
Low Risk
Documentation and example-only HTML/README changes with no impact on library or production integration paths.
Overview
The browser example no longer imports
@worldcoin/idkit-corethrough Vite or toggles between workspace and CDN builds. It always loads@worldcoin/idkit-core@4.2.0via a<script>tag on unpkg and useswindow.IDKitfor verification flows.The “Use CDN version” checkbox and dynamic script loader are removed; the config panel always shows the pinned CDN URL. README now describes this as the default way to exercise the published global bundle (
idkit.global.js) and WASM sibling, instead of requiring a rootpnpm buildfor localdist/.Reviewed by Cursor Bugbot for commit 1425c82. Bugbot is set up for automated code reviews on this repo. Configure here.