Skip to content

feat(swift): expose IdentityCheck preset in Swift SDK#220

Merged
chipp merged 1 commit into
mainfrom
vladimirburdukov/identity-attributes-swift
May 28, 2026
Merged

feat(swift): expose IdentityCheck preset in Swift SDK#220
chipp merged 1 commit into
mainfrom
vladimirburdukov/identity-attributes-swift

Conversation

@chipp

@chipp chipp commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adds identityCheck() public function to the Swift SDK, returning a .identityCheck preset with a list of IdentityAttribute values and an optional legacySignal
  • Adds tests covering the preset construction and legacySignal pass-through
  • Updates the sample app to include an Identity Check option (minimum age 21, nationality JPN, passport)
  • Fixes build-swift.sh to use cargo run -p uniffi-bindgen (no ambient uniffi-bindgen binary required) and adds --no-format to skip swiftformat
  • Updates swift/README.md with a usage snippet

Test plan

  • swift test passes in swift/ (new identityCheck tests)
  • Sample app builds and the Identity Check preset appears in the picker
  • CI Swift job passes

@vercel

vercel Bot commented Apr 21, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
idkit-js-example Ready Ready Preview, Comment May 27, 2026 6:36pm

Request Review

This was referenced Apr 21, 2026
Merged
Merged
Merged
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from f1d81ef to 71773ed Compare April 21, 2026 11:42
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from ce5b9d7 to 4a76aa5 Compare April 21, 2026 11:42
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 4a76aa5 to 6413091 Compare April 21, 2026 11:58
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 71773ed to 1371a3b Compare April 21, 2026 11:58
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 1371a3b to 61dc591 Compare April 21, 2026 12:27
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 6413091 to ce6d884 Compare April 21, 2026 12:27
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 61dc591 to f2b27a9 Compare April 21, 2026 16:39
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from ce6d884 to 519e823 Compare April 21, 2026 16:39
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 519e823 to fc81712 Compare April 23, 2026 13:59
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from f2b27a9 to c96f05b Compare April 23, 2026 13:59
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from c96f05b to 9206c6f Compare April 23, 2026 14:11
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from fc81712 to 35d8ccf Compare April 23, 2026 14:11
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 35d8ccf to eb9e87b Compare April 23, 2026 15:19
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 9206c6f to 25033ea Compare April 23, 2026 15:19
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from eb9e87b to f4c67a7 Compare April 23, 2026 15:48
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 25033ea to da08539 Compare April 23, 2026 15:48
@chipp chipp changed the base branch from vladimirburdukov/identity-attributes to graphite-base/220 April 28, 2026 14:22
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 4ea9a91 to 16ece0f Compare May 1, 2026 16:34
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 16ece0f to fe0d86f Compare May 1, 2026 16:44
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 961b87a to 59cc4a6 Compare May 1, 2026 16:44
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from fe0d86f to e77627a Compare May 1, 2026 16:49
@chipp chipp force-pushed the vladimirburdukov/identity-attributes branch from 07ea956 to dcf24dc Compare May 1, 2026 17:06
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from e77627a to d87ea5c Compare May 1, 2026 17:06
Base automatically changed from vladimirburdukov/identity-attributes to main May 4, 2026 19:54
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from d87ea5c to 6e4b9eb Compare May 5, 2026 17:51
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 6e4b9eb to 37d2e5c Compare May 7, 2026 17:22
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 37d2e5c to a6577f0 Compare May 19, 2026 15:36
@chipp chipp changed the base branch from main to vladimirburdukov/remove-require-proof-of-humanity-from-identitycheck-preset May 19, 2026 15:37
@chipp chipp force-pushed the vladimirburdukov/remove-require-proof-of-humanity-from-identitycheck-preset branch from d7f43e2 to 4a938ef Compare May 20, 2026 11:24
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from a6577f0 to 1bee3f6 Compare May 20, 2026 11:40
Base automatically changed from vladimirburdukov/remove-require-proof-of-humanity-from-identitycheck-preset to main May 20, 2026 11:49
@chipp chipp force-pushed the vladimirburdukov/identity-attributes-swift branch from 1bee3f6 to 682a9a7 Compare May 20, 2026 11:53
@chipp chipp marked this pull request as ready for review May 27, 2026 18:01
Takaros999
Takaros999 approved these changes May 28, 2026
View reviewed changes
Comment thread swift/Examples/IDKitSampleApp/IDKitSampleApp/ContentView.swift
deviceLegacy(signal: signal)
case .selfieCheck:
selfieCheckLegacy(signal: signal)
case .identityCheckWith:

@Takaros999 Takaros999 May 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, if we could make this dynamic (can be follow up pr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Takaros999 Takaros999 Takaros999 approved these changes

@paolodamico paolodamico Awaiting requested review from paolodamico paolodamico is a code owner

@andy-t-wang andy-t-wang Awaiting requested review from andy-t-wang andy-t-wang is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski SeanROlszewski is a code owner

@Guardiola31337 Guardiola31337 Awaiting requested review from Guardiola31337 Guardiola31337 is a code owner

@Gr1dlock Gr1dlock Awaiting requested review from Gr1dlock Gr1dlock is a code owner

@murph murph Awaiting requested review from murph murph is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chipp @Takaros999