Detail the error types in createMetric and batchCreateMetrics. (#1005)

world-federation-of-advertisers · May 18, 2023 · ba15186 · ba15186
1 parent 1834763
commit ba15186
Showing 1 changed file with 26 additions and 2 deletions.
diff --git a/src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/MetricsService.kt b/src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/MetricsService.kt
@@ -1172,7 +1172,20 @@ class MetricsService(
       try {
         internalMetricsStub.createMetric(internalCreateMetricRequest)
       } catch (e: StatusException) {
-        throw Exception("Unable to create the metric in the reporting database.", e)
+        throw when (e.status.code) {
+            Status.Code.NOT_FOUND ->
+              Status.NOT_FOUND.withDescription("Reporting set used in the metric not found.")
+            Status.Code.FAILED_PRECONDITION ->
+              Status.FAILED_PRECONDITION.withDescription(
+                "Unable to create the metric. The measurement consumer not found."
+              )
+            else ->
+              Status.UNKNOWN.withDescription(
+                "Unable to create the metric in the reporting database."
+              )
+          }
+          .withCause(e)
+          .asRuntimeException()
       }
 
     if (internalMetric.state == Metric.State.RUNNING) {
@@ -1227,7 +1240,18 @@ class MetricsService(
           .metricsList
           .filter { internalMetric -> internalMetric.state == Metric.State.RUNNING }
       } catch (e: StatusException) {
-        throw Exception("Unable to create the metric in the reporting database.", e)
+        throw when (e.status.code) {
+            Status.Code.NOT_FOUND ->
+              Status.NOT_FOUND.withDescription("Reporting set used in metrics not found.")
+            Status.Code.FAILED_PRECONDITION ->
+              Status.FAILED_PRECONDITION.withDescription(
+                "Unable to create the metrics. The measurement consumer not found."
+              )
+            else ->
+              Status.UNKNOWN.withDescription("Unable to create metrics in the reporting database.")
+          }
+          .withCause(e)
+          .asRuntimeException()
       }
 
     measurementSupplier.createCmmsMeasurements(internalMetrics, principal)