fix: resolve issues with ExchangeRate.host #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I'm just looking into sorting out the tests as part of this change. 👍🏻 |
|
anytime, sadly i have no enough time to help with tests. i will leave it to you. |
owenvoke
force-pushed
the
fix/exhange-host
branch
from
a2124df to
ca53a97
Compare
owenvoke
changed the title
owenvoke
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
I've worked on the fixes required for this. Due to this change being technically a breaking change, we are going to release this fix as v2.0.0
Also, as part of v2.0.0, we are going to change the default driver to frankfurter so that users can get started without needing an API token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #18
@owenvoke here you go.