-
Notifications
You must be signed in to change notification settings - Fork 3
Implement PKCE and sealed OAuth state flow #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
851c553
Implement PKCE and CSRF protection
devin-ai-integration[bot] 7bd2c83
Restore @workos-inc/node to runtime dependencies
devin-ai-integration[bot] 1218911
Restore JSDoc above createAuthWithCodeResponse
devin-ai-integration[bot] 0c4956a
Thread request through PKCE cookie Secure detection
devin-ai-integration[bot] 72f3137
Rewrite README and add migration guide for 0.10.0
devin-ai-integration[bot] 4fe1173
Format pkce.spec.ts
devin-ai-integration[bot] 4806fc7
Address follow-up review on PKCE cookie Secure detection
devin-ai-integration[bot] 9e92ec7
Format pkce.spec.ts
devin-ai-integration[bot] 0c3f9a4
Sanitize returnPathname and preserve hash on callback
devin-ai-integration[bot] 697e81e
Preserve explicit returnPathname='/' in callback
devin-ai-integration[bot] f948933
Clear PKCE cookies on sign-out; doc sign-in endpoint
devin-ai-integration[bot] 001edb6
Format session.ts
devin-ai-integration[bot] 5fcbbb9
Validate iss claim on access token
devin-ai-integration[bot] 11626f6
Clear PKCE cookie on error callback
devin-ai-integration[bot] 45d5024
Simplify PKCE callback comments and cleanup helper
nicknisi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@workos-inc/nodedropped from runtime dependencies@workos-inc/nodewas removed fromdependenciesand kept only indevDependencies, butworkos.tsdoesimport { WorkOS } from '@workos-inc/node'— a non-type, runtime import. Any consumer who installs this package fresh (without@workos-inc/nodein their own project) will get a module-not-found error at runtime.The PR description says this was a version bump (
^7.41.0→^8.9.0), not a removal, so this looks like an unintentional regression. It should either be restored todependenciesor, if the intent is for apps to manage the version themselves, explicitly added topeerDependencies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — restored in 7bd2c83.
@workos-inc/node@^8.9.0is back independencies, and I also realigned thedevDependenciespin from^8.13.0to^8.9.0so both entries reference the same range.