Skip to content

Update internal dev dependencies#49

Merged
chaance merged 4 commits into
mainfrom
chance/update-dev-deps
Dec 11, 2025
Merged

Update internal dev dependencies#49
chaance merged 4 commits into
mainfrom
chance/update-dev-deps

Conversation

@chaance

@chaance chaance commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread tsconfig.json
"lib": ["DOM", "ES2022", "DOM.Iterable"],
"jsx": "react",
"module": "Node16",
"moduleResolution": "Node",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node is an invalid moduleResolution when module is set to Node16. The CJS build config reverts this since it uses CJS module format.

@greptile-apps

greptile-apps Bot commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Greptile Overview

Greptile Summary

This PR updates internal dev dependencies to their latest versions and fixes TypeScript configuration for proper module resolution.

Key Changes:

  • Updated dev dependencies: testing libraries, TypeScript tooling, prettier, and react-router
  • Added @workos-inc/node ^7.77.0 to devDependencies (note: v7.41.0 already exists in dependencies)
  • Added typecheck script to run type checking without emitting files
  • Fixed tsconfig.json to use moduleResolution: Node16 (matching module: Node16)
  • Added explicit moduleResolution: Node override in tsconfig-cjs.json for CommonJS build

Notes:

  • The addition of @workos-inc/node to devDependencies appears intentional for having a newer version available during development/testing while maintaining compatibility with the older production version
  • TypeScript config changes ensure proper module resolution for both ESM and CommonJS builds

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are internal dev dependency updates with no runtime code modifications. TypeScript configuration fixes ensure proper module resolution. No custom rules violated (no SQL, CORS, sensitive logging, TypeORM, React components, or TLS changes).
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
package.json 5/5 Updated dev dependencies to latest versions, added typecheck script, and included @workos-inc/node v7.77.0 in devDependencies (already exists in dependencies at v7.41.0)
package-lock.json 5/5 Lockfile updated to reflect new dev dependency versions
tsconfig.json 5/5 Changed moduleResolution from Node to Node16 to align with module: Node16
tsconfig-cjs.json 5/5 Added explicit moduleResolution: Node to override parent config's Node16 setting for CommonJS build

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant NPM as NPM Registry
    participant TS as TypeScript Compiler
    participant Build as Build System

    Dev->>NPM: Update dev dependencies
    NPM-->>Dev: Install @testing-library/jest-dom ^6.9.1
    NPM-->>Dev: Install @testing-library/react ^16.3.0
    NPM-->>Dev: Install @types/node ^24.10.3
    NPM-->>Dev: Install @typescript-eslint/eslint-plugin ^7.18.0
    NPM-->>Dev: Install @workos-inc/node ^7.77.0 (dev)
    NPM-->>Dev: Install eslint ^8.57.1
    NPM-->>Dev: Install prettier ^3.7.4
    NPM-->>Dev: Install react-router ^7.10.1
    NPM-->>Dev: Install typescript ^5.9.3
    
    Dev->>TS: Update tsconfig.json
    Note over TS: moduleResolution: Node → Node16
    
    Dev->>TS: Update tsconfig-cjs.json
    Note over TS: Add moduleResolution: Node for CJS
    
    Dev->>Build: Add typecheck script
    Build->>TS: Run tsc --noEmit
    TS-->>Build: Type checking complete
    
    Dev->>Build: npm run build
    Build->>TS: Compile with tsconfig-cjs.json
    TS-->>Build: CommonJS output generated
Loading

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@chaance chaance merged commit aa8c305 into main Dec 11, 2025
9 checks passed
@chaance chaance deleted the chance/update-dev-deps branch December 11, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants