-
-
Notifications
You must be signed in to change notification settings - Fork 185
Feature/collapsed UI menu #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hey @RismanRJ, thanks for the PR. It's getting good, but what I can see here: Is the topbar not expanding when it collapses, and the collapse icon should maybe be smaller and aligned? I tried to make these adjustments but it's still not working as expected, here the branch: I tried to change the grid space when it's collapsed but there's remaining space So there's still some issues to address to make this work. Do you want to continue to try? Feel free to apply my changes and go from there if you have a solution. |
@alexanmtz Hey thanks for the reply and I will look through the issue and try to close the PR ASAP thank you |
@RismanRJ we did changes recently to support mobile menu navigation on profile, so you need to sync with master before continue and resolve the conflicts |
@alexanmtz Okay sure 👍 |
@alexanmtz Resolved the conflicts. |
@RismanRJ , thank you for the updates. Could you let me know if you resolved the issues with the alignment and the top bar not accommodating? Can you take a screenshot of your results so we can verify if everything is in order? Thank you 🙏 |
@alexanmtz Can you just explain the issue more in detail? |
Hey @RismanRJ , I can't see your change with a working solution. Have you checked your PR? |
Description
collapsed
state usinguseState
.ChevronLeftIcon
andChevronRightIcon
from@mui/icons-material
.responsiveLogo
) is displayed.logo
) is shown.useMediaQuery
.Purpose
Enhances the UX by allowing users to collapse the sidebar for more content space. Makes the layout responsive and consistent across screen sizes.
Solution
collapsed
state inSideMenu.tsx
.<ChevronLeftIcon />
when expanded<ChevronRightIcon />
when collapsedcollapsed
andisMobile
.makeStyles
to adapt styles dynamically.Checklist
Related Issues