bug修复 #20
Merged
bug修复 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
不好意思，写的时候写急了，哈哈哈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
感谢您这两天在webman上面的解答，再次感谢
升级到1.2.3后，出现了2个bug
1、InstanceRegistrarProcess的第54行的判断，逻辑正好相反，判断临时实例，是用true，而不是false。
2、因为默认的app.php文件中ephemeral的值还是字符串类型。
InstanceRegistrarProcess还是这个文件，第56行的list($serviceName, $ip, $port, $option) = $this->instanceRegistrars[$name];
会导致，前面$option['ephemeral']转换成的布尔值，再次被换成字符串，进而导致InstanceProvider文件的beat方法报错，因为第5个参数ephemeral需要是布尔值
该pr已经尝试修复了上述问题，谢谢