Skip to content

Add size to RemoteMedia #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Add size to RemoteMedia #647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ _None._

### New Features

- Add `tag` parameter to `PostServiceRemoteOptions` [#634]
- Add `transfer` case to `DomainType` case [#642]
- Add `size` property to `RemoteMedia` [#647]

## 8.10.0

Expand Down
3 changes: 2 additions & 1 deletion WordPressKit/MediaServiceRemoteREST.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ + (NSArray *)remoteMediaFromJSONArray:(NSArray *)jsonMedia

+ (RemoteMedia *)remoteMediaFromJSONDictionary:(NSDictionary *)jsonMedia
{
RemoteMedia * remoteMedia=[[RemoteMedia alloc] init];
RemoteMedia *remoteMedia = [[RemoteMedia alloc] init];
remoteMedia.mediaID = [jsonMedia numberForKey:@"ID"];
remoteMedia.url = [NSURL URLWithString:[jsonMedia stringForKey:@"URL"]];
remoteMedia.guid = [NSURL URLWithString:[jsonMedia stringForKey:@"guid"]];
Expand All @@ -412,6 +412,7 @@ + (RemoteMedia *)remoteMediaFromJSONDictionary:(NSDictionary *)jsonMedia
remoteMedia.remoteThumbnailURL = [jsonMedia stringForKeyPath:@"thumbnails.fmt_std"];
remoteMedia.videopressGUID = [jsonMedia stringForKey:@"videopress_guid"];
remoteMedia.length = [jsonMedia numberForKey:@"length"];
remoteMedia.size = [jsonMedia stringForKey:@"size"];
return remoteMedia;
}

Expand Down
1 change: 1 addition & 0 deletions WordPressKit/RemoteMedia.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
@property (nonatomic, strong, nullable) NSDictionary *exif;
@property (nonatomic, strong, nullable) NSString *videopressGUID;
@property (nonatomic, strong, nullable) NSNumber *length;
@property (nonatomic, strong, nullable) NSString *size;
@property (nonatomic, strong, nullable) NSString *remoteThumbnailURL;

@end