-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/7404 settings gravatar site icon #8870
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to MeHeaderView, except less interactions and in Swift.
… on gravatar results.
Closing because this PR has extra commits that shouldn't be here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7404
Partial implementation of 7404. This PR has the gravatar and text button displaying in the
Me > My Profile
screen.To test:
Me > My Profile
and tap on the text button.1a. If a profile photo does not exist, the text button will say "Add a Profile Photo" and the default gravatar placeholder image displays.
1b. If the a profile photo is in use the text button will say "Update Profile Photo" and the current profile photo displays.
Me > My Profile
section are reflected in theMe
screen.Me
screen, they are reflected in theMe > My Profile
screen as well.