Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/7404 settings gravatar site icon #8870

Closed
wants to merge 25 commits into from

Conversation

mindgraffiti
Copy link
Contributor

Fixes #7404

Partial implementation of 7404. This PR has the gravatar and text button displaying in the Me > My Profile screen.

To test:

  1. Navigate to Me > My Profile and tap on the text button.
    1a. If a profile photo does not exist, the text button will say "Add a Profile Photo" and the default gravatar placeholder image displays.
    1b. If the a profile photo is in use the text button will say "Update Profile Photo" and the current profile photo displays.
  2. Tapping on the text button presents the gravatar picker: a photo album called "Selfies" appears.
  3. Tapping on the profile image also presents the gravatar picker.
  4. Changes from the Me > My Profile section are reflected in the Me screen.
  5. If changes are made to the profile photo in the Me screen, they are reflected in the Me > My Profile screen as well.

Similar to MeHeaderView, except less interactions and in Swift.
@mindgraffiti
Copy link
Contributor Author

Closing because this PR has extra commits that shouldn't be here.

@mindgraffiti mindgraffiti deleted the issue/7404-settings-gravatar-site-icon branch March 9, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant