-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Reader: Update the main tabs #24441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Reader: Update the main tabs #24441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
App Name | Jetpack | |
Configuration | Release-Alpha | |
Build Number | 27257 | |
Version | PR #24441 | |
Bundle ID | com.jetpack.alpha | |
Commit | 760c881 | |
Installation URL | 4rhpa3l9it8u0 |
|
App Name | WordPress | |
Configuration | Release-Alpha | |
Build Number | 27257 | |
Version | PR #24441 | |
Bundle ID | org.wordpress.alpha | |
Commit | 760c881 | |
Installation URL | 0gk19t8l1qui8 |
crazytonyli
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ReaderHomeViewController
)Note: take into account that this not production code. It was created as quickly as possible so we could ship a prototype. It will not affect the main apps, but there are a few places where I needed to update the production code – this will need to be checked.
To test:
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-10.at.13.33.23.mp4
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: