Skip to content

Reader: Update the main tabs #24441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 11, 2025
Merged

Reader: Update the main tabs #24441

merged 25 commits into from
Apr 11, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 10, 2025

Changes:

  • Rename "Recent" tab to "Home" (and introduce a separate ReaderHomeViewController)
  • Add "Create Post" navigation bar button on the "Home" screen
  • Remove scroll-to-top button. Based on analytics, people don't use it, and, unlike jpios, you can just tap on the tab bar item now
  • Implement scroll-to-top by tapping on tab bar items
  • Update the "Following" screen: add tabs to show your lists and tags, fix push on selection, add support for adding items, etc
  • Add search to "Discover"
  • Bind notifiations badge on tab bar item
  • Add new "Me" Reader-specific tab. It shows site dashboard, your profile card, and allows you to open the regular "Me" screen with profile settings

Note: take into account that this not production code. It was created as quickly as possible so we could ship a prototype. It will not affect the main apps, but there are a few places where I needed to update the production code – this will need to be checked.

To test:

  • Change the "WPAppBrand" value in the Jetpack app to "reader"
  • Follow the changes – smoke test
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-10.at.13.33.23.mp4

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Apr 10, 2025
@kean kean added this to the 25.9 milestone Apr 10, 2025
@kean kean requested a review from crazytonyli April 10, 2025 17:42
@dangermattic
Copy link
Collaborator

2 Warnings
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27257
VersionPR #24441
Bundle IDcom.jetpack.alpha
Commit760c881
Installation URL4rhpa3l9it8u0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27257
VersionPR #24441
Bundle IDorg.wordpress.alpha
Commit760c881
Installation URL0gk19t8l1qui8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean added this pull request to the merge queue Apr 11, 2025
Merged via the queue into trunk with commit 57ce314 Apr 11, 2025
31 checks passed
@kean kean deleted the task/reader-minor-changes branch April 11, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants