Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Share action to site link context menu on dashboard #23935

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Add Share action to site link context menu on dashboard #23935

merged 4 commits into from
Jan 2, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 2, 2025

Changes:

  • Add Share action to site link context menu on dashboard
  • Replace some of the common button titles with SharedStrings.Button.*
Screenshot 2025-01-02 at 1 24 47 PM

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the My Site label Jan 2, 2025
@kean kean added this to the 25.7 milestone Jan 2, 2025
@kean kean changed the base branch from trunk to christmas-feature-branch January 2, 2025 18:25
@kean kean force-pushed the task/add-share-action branch from cc8e863 to 4c26d71 Compare January 2, 2025 18:35
@kean kean merged commit be2aa0d into christmas-feature-branch Jan 2, 2025
9 of 22 checks passed
@kean kean deleted the task/add-share-action branch January 2, 2025 18:43
@kean kean mentioned this pull request Jan 2, 2025
Open
14 tasks
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23935-6b1e72a
Version25.6
Bundle IDorg.wordpress.alpha
Commit6b1e72a
App Center BuildWPiOS - One-Offs #11247
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23935-6b1e72a
Version25.6
Bundle IDcom.jetpack.alpha
Commit6b1e72a
App Center Buildjetpack-installable-builds #10284
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
My Site
Projects
None yet
Milestone
25.7
Development

Successfully merging this pull request may close these issues.
2 participants
@kean @wpmobilebot