Skip to content

Remove unsupported reblog notification type #22723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

justtwago
Copy link
Contributor

Fixes #22676

This PR removes unsupported unused reblog notification type.

To test:
Smoke test the notifications. Make sure everything works as usual and reblogging does not trigger any notification.

Regression Notes

  1. Potential unintended areas of impact
    Notifications

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual tests

  3. What automated tests I added (or what prevented me from doing so)
    Code removal. There are no tests for this class.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22723-e52dcf0
Version24.3
Bundle IDorg.wordpress.alpha
Commite52dcf0
App Center BuildWPiOS - One-Offs #9012
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22723-e52dcf0
Version24.3
Bundle IDcom.jetpack.alpha
Commite52dcf0
App Center Buildjetpack-installable-builds #8049
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from feature/notifications_refresh_p1 to trunk February 28, 2024 18:42
Copy link
Contributor

@alpavanoglu alpavanoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good ✅

@justtwago justtwago merged commit 2aae8f3 into trunk Feb 29, 2024
@justtwago justtwago deleted the tech/22676-remove-reblog-notification branch February 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍎 Remove deprecated reblog notification type
3 participants