Offline Mode: Sync Publishing #22689

kean · 2024-02-23T01:56:36Z

To test:

Important

Make sure to enable the .offlineMode feature flag.

Tap "+" to create a new post
Add content and tap "Publish"
Verify that the pre-publishing sheet is shown
Tap "Publish"
Verify that that sheet is disabled and can't be dismissed during publishing
Verify that if request fails, a snackbar is shown (note: it should not have a "Retry" button)
Verify that if request succeed, the editor is dismissed

This is the only scenario that is now officially supported. We'll need more tests, including automated test in the future PRs.

Regression Notes

Potential unintended areas of impact: Publishing
What I did to test those areas of impact (or what existing automated tests I relied on): manual
What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

kean · 2024-02-23T01:57:18Z

WordPress/Classes/Models/BasePost.h

@@ -35,6 +35,8 @@ NS_ASSUME_NONNULL_BEGIN

 /**
 BOOL flag set to true if the post is first time published.
+
+ - note: Deprecated (kahu-offline-mode)


I suggest using this marker for anything that's scheduled for removal once the project is live. I'm not "officially"deprecating these APIs to avoid polluting the project with warnings.

kean · 2024-02-23T01:59:19Z

WordPress/Classes/Services/PostCoordinator.swift

+    ///
+    /// - warning: Work-in-progress (kahu-offline-mode)
+    @MainActor
+    func _publish(_ post: AbstractPost) async throws {


I'm underscoring the methods that are work-in-progress and are only designed to be used in the scope of the project. It also helps avoid the name conflicts.

kean · 2024-02-23T02:00:09Z

WordPress/Classes/Services/PostCoordinator.swift

+            notifyNewPostPublished()
+        }
+        SearchManager.shared.indexItem(post)
+        AppRatingUtility.shared.incrementSignificantEvent()


Everything non-editor related is now handled by PostCoordinator to allow you to safely publish outside of the editor.

Noting that it no longer sets post.shouldAttemptAutoUpload = true and no longer uses isFirstTimePublish which should never have been part of the model layer.

kean · 2024-02-23T02:01:32Z

WordPress/Classes/Services/PostRepository.swift

+    ///
+    /// - warning: Work-in-progress (kahu-offline-mode)
+    @MainActor
+    func _upload(_ parameters: RemotePost, for post: AbstractPost) async throws {


parameters: RemotePost – this will definitely change, but the idea is that by bringing back synchronous operations, we need a way to:

Send the request with new parameters without updating the database to make sure there is nothing to revert if it fails

Be able to send only what's changes and that's coming in the next scopes

kean · 2024-02-23T02:02:55Z

WordPress/Classes/Services/PostRepository.swift

+                post = original
+            }
+            PostHelper.update(post, with: uploadedPost, in: context)
+            PostService(managedObjectContext: context)


This method, including updateMediaFor is pretty much one-to-one replacement to the Objective-C version from PostService that Tony replaced with PostRepository.

updateMediaFor is an odd one. It set the postID for assets, but it makes little scene because asset->post is a one-to-many relationship.

kean · 2024-02-23T02:04:53Z

WordPress/Classes/ViewRelated/Post/PostEditor+Publish.swift

-        let viewController = PrepublishingViewController(post: post, identifiers: prepublishingIdentifiers) { [weak self] result in
-            switch result {
-            case .completed(let post):
-                self?.post = post


This was a no-op because the post instance never changes.

wpmobilebot · 2024-02-23T02:05:21Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22689-5205217
	Version	24.3
	Bundle ID	com.jetpack.alpha
	Commit	`5205217`
	App Center Build	jetpack-installable-builds #8105

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot · 2024-02-23T02:05:23Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22689-5205217
	Version	24.3
	Bundle ID	org.wordpress.alpha
	Commit	`5205217`
	App Center Build	WPiOS - One-Offs #9062

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

momo-ozawa

Works as described!

I wonder if we should continue showing the success notice message when creating a post/page from the FAB. IMO I don't think the implicit indication of closing the editor is enough - I'd expect to see some explicit indication that the post was uploaded (if I'm on the My Site screen).

sync-publishing-from-fab.mp4

WordPress/Classes/Services/PostRepository.swift

Co-authored-by: Momo Ozawa <[email protected]>

momo-ozawa

Approving to unblock - lmk what you think of adding an explicit message to acknowledge a successful upload for the FAB flow.

kean · 2024-03-04T17:51:35Z

Test cases for notifications:

Success (Notice)

Publish a post
Verify that a success notice is shown with a "View" button
Tap "View" and verify that the success screen is shown

Success (Local Notification)

Tap "Publish" and quickly close the app
Verify that a success local notification is shown
Note: tapping on it just opens the post list

Failure (Notice)

When connection is down
Tap "Publish"
Verify that a failure notice is shown with no buttons

Failure (Local Notification)

When connection is down
Tap "Publish" and quickly close the app
Verify that a failure local notification is shown

momo-ozawa

Test cases work as described

kean added 2 commits February 20, 2024 21:39

Add PostRepository.publish

5c34edd

Integrate PostRepository.publish in the Prepublishing sheet

ababbc2

kean added [Type] Task Offline Mode (Sync Issues) labels Feb 23, 2024

kean added this to the Pending milestone Feb 23, 2024

kean commented Feb 23, 2024

View reviewed changes

kean force-pushed the task/sync-publishing-p2 branch from a83b389 to 0a155d2 Compare February 23, 2024 02:06

kean added 3 commits February 23, 2024 11:53

Add PostCoordinator.publish

73ac370

Add loading state to PrepublishingViewController

40c04a3

Remove the success notice for now

8047234

kean force-pushed the task/sync-publishing-p2 branch from 0a155d2 to 8047234 Compare February 23, 2024 18:56

kean requested a review from momo-ozawa February 23, 2024 19:01

kean marked this pull request as ready for review February 23, 2024 19:02

kean added 2 commits February 23, 2024 14:11

Remove Retry from a failure notice

7f54c38

Fix typo

fb5230e

momo-ozawa reviewed Feb 29, 2024

View reviewed changes

WordPress/Classes/Services/PostRepository.swift Outdated Show resolved Hide resolved

WordPress/Classes/Services/PostRepository.swift Outdated Show resolved Hide resolved

kean and others added 2 commits March 3, 2024 14:11

Update WordPress/Classes/Services/PostRepository.swift

80ebb4f

Co-authored-by: Momo Ozawa <[email protected]>

Update WordPress/Classes/Services/PostRepository.swift

66a865c

Co-authored-by: Momo Ozawa <[email protected]>

momo-ozawa approved these changes Mar 4, 2024

View reviewed changes

Reimplement post notices

5205217

momo-ozawa approved these changes Mar 5, 2024

View reviewed changes

kean modified the milestones: Pending, 24.6 Mar 5, 2024

kean merged commit a66adde into trunk Mar 5, 2024
23 of 24 checks passed

kean deleted the task/sync-publishing-p2 branch March 5, 2024 13:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Offline Mode: Sync Publishing #22689

Offline Mode: Sync Publishing #22689

kean commented Feb 23, 2024 •

edited

Loading

kean Feb 23, 2024

kean Feb 23, 2024

kean Feb 23, 2024

kean Feb 23, 2024

kean Feb 23, 2024

kean Feb 23, 2024

wpmobilebot commented Feb 23, 2024 •

edited

Loading

wpmobilebot commented Feb 23, 2024 •

edited

Loading

momo-ozawa left a comment

momo-ozawa left a comment

kean commented Mar 4, 2024

momo-ozawa left a comment

Offline Mode: Sync Publishing #22689

Offline Mode: Sync Publishing #22689

Conversation

kean commented Feb 23, 2024 • edited Loading

Regression Notes

kean Feb 23, 2024

Choose a reason for hiding this comment

kean Feb 23, 2024

Choose a reason for hiding this comment

kean Feb 23, 2024

Choose a reason for hiding this comment

kean Feb 23, 2024

Choose a reason for hiding this comment

kean Feb 23, 2024

Choose a reason for hiding this comment

kean Feb 23, 2024

Choose a reason for hiding this comment

wpmobilebot commented Feb 23, 2024 • edited Loading

wpmobilebot commented Feb 23, 2024 • edited Loading

momo-ozawa left a comment

Choose a reason for hiding this comment

momo-ozawa left a comment

Choose a reason for hiding this comment

kean commented Mar 4, 2024

momo-ozawa left a comment

Choose a reason for hiding this comment

kean commented Feb 23, 2024 •

edited

Loading

wpmobilebot commented Feb 23, 2024 •

edited

Loading

wpmobilebot commented Feb 23, 2024 •

edited

Loading