Remove Today card from Insights if Traffic feature flag is enabled

[staskus]

Fixes #22662

To test:

1. Disable Stats Traffic feature flag
2. Open Stats -> Insights
3. Open Insight Management on Top Right corner
4. Add Today Stats card
5. Close Stats
6. Disable Stats Traffic feature flag
7. Open Stats -> Insights
8. Confirm Today Stats card is not visible
9. Open Insight Management on Top Right corner
10. Confirm Today Stats card option is not available

Regression Notes

1. Potential unintended areas of impact

None

2. What I did to test those areas of impact (or what existing automated tests I relied on)

None

3. What automated tests I added (or what prevented me from doing so)

None

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22675-e19a6fa
	Version	24.3
	Bundle ID	org.wordpress.alpha
	Commit	e19a6fa
	App Center Build	WPiOS - One-Offs #8918

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22675-e19a6fa
	Version	24.3
	Bundle ID	com.jetpack.alpha
	Commit	e19a6fa
	App Center Build	jetpack-installable-builds #7948

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[guarani]

Works great, thanks!

Maybe something like this would be more readable:

RemoteFeatureFlag.statsTrafficTab.enabled() ? nil : .insightsTodaysStats,`

to avoid the hardcoded "8", but I think it's still fine as-is.

[irfano]

LGTM! 👍🏻 It's not working until the app is restarted. But configs should already be fetched only after restarting the app, so it's fine.

[staskus]

It's not working until the app is restarted. But configs should already be fetched only after restarting the app, so it's fine.

Thanks for testing! It should be working without restarting the app but it requires rebuilding the Stats view.

[staskus]

Maybe something like this would be more readable:

@guarani yes, I agree! I made the improvement.