Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications Refresh (Phase 1) #22524

Merged
merged 185 commits into from
Feb 28, 2024
Merged

Conversation

salimbraksa
Copy link
Contributor

@salimbraksa salimbraksa commented Feb 1, 2024

Subtasks

List UI

Inline Actions

Navigation bar

Details View

Push notifications

Other

Test Instructions

Each issue listed above should be tested individually

Also check:

  • Test List UI changes: pdcxQM-39Z-p2
  • Navigation Bar and Inline Changes: pdcxQM-3a7-p2

Regression Notes

  1. Potential unintended areas of impact

    • TODO
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • TODO
  3. What automated tests I added (or what prevented me from doing so)

    • TODO

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 1, 2024

3 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 1, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22524-f6202c5
Version24.3
Bundle IDorg.wordpress.alpha
Commitf6202c5
App Center BuildWPiOS - One-Offs #9009
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 1, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22524-f6202c5
Version24.3
Bundle IDcom.jetpack.alpha
Commitf6202c5
App Center Buildjetpack-installable-builds #8046
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@salimbraksa salimbraksa force-pushed the feature/notifications_refresh_p1 branch from 0167461 to 11a6fac Compare February 5, 2024 14:57
alpavanoglu and others added 24 commits February 23, 2024 21:16
…post-inline-action

# Conflicts:
#	WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController/NotificationsViewController.swift
#	WordPress/Classes/ViewRelated/Views/List/NotificationsList/NotificationsTableViewCellContent.swift
#	WordPress/WordPress.xcodeproj/project.pbxproj
@hassaanelgarem hassaanelgarem marked this pull request as ready for review February 27, 2024 13:54
@antonis antonis added this to the 24.4 milestone Feb 27, 2024
Copy link
Contributor

@alpavanoglu alpavanoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As every change in this branch has been reviewed and tested, I have skimmed through the code changes and ran a general test. I did not notice any blockers. I think for the next iteration, we should keep more focus on removing legacy code.

@alpavanoglu alpavanoglu merged commit 381c907 into trunk Feb 28, 2024
24 of 27 checks passed
@alpavanoglu alpavanoglu deleted the feature/notifications_refresh_p1 branch February 28, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants