-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications Refresh (Phase 1) #22524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr22524-f6202c5 | |
Version | 24.3 | |
Bundle ID | org.wordpress.alpha | |
Commit | f6202c5 | |
App Center Build | WPiOS - One-Offs #9009 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr22524-f6202c5 | |
Version | 24.3 | |
Bundle ID | com.jetpack.alpha | |
Commit | f6202c5 | |
App Center Build | jetpack-installable-builds #8046 |
0167461
to
11a6fac
Compare
Co-authored-by: Gio Lodi <[email protected]> Fix build error
…ssing-notification-selection-color
…post-inline-action # Conflicts: # WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController/NotificationsViewController.swift # WordPress/Classes/ViewRelated/Views/List/NotificationsList/NotificationsTableViewCellContent.swift # WordPress/WordPress.xcodeproj/project.pbxproj
…ve non-nullable init" This reverts commit f999a4a.
alpavanoglu
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As every change in this branch has been reviewed and tested, I have skimmed through the code changes and ran a general test. I did not notice any blockers. I think for the next iteration, we should keep more focus on removing legacy code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtasks
List UI
Inline Actions
Navigation bar
Details View
Push notifications
Other
Test Instructions
Each issue listed above should be tested individually
Also check:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: