-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Posts & Pages: Page hierarchy #21853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Posts & Pages: Page hierarchy #21853
Conversation
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr21853-a4ddecd | |
Version | 23.4 | |
Bundle ID | org.wordpress.alpha | |
Commit | a4ddecd | |
App Center Build | WPiOS - One-Offs #7520 |
|
App Name | ![]() |
|
Configuration | Release-Alpha | |
Build Number | pr21853-a4ddecd | |
Version | 23.4 | |
Bundle ID | com.jetpack.alpha | |
Commit | a4ddecd | |
App Center Build | jetpack-installable-builds #6548 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the subdirectory icon tint color should be lighter? (ref: https://a8c.slack.com/archives/C04SFL0RP51/p1697134579124589)
Otherwise, LGTM!
@@ -11,6 +11,8 @@ final class PageListCell: UITableViewCell, Reusable { | |||
private let badgesLabel = UILabel() | |||
private let featuredImageView = CachedAnimatedImageView() | |||
private let ellipsisButton = UIButton(type: .custom) | |||
private let contentStackView = UIStackView() | |||
private var indentionIconView = UIImageView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit]
private var indentionIconView = UIImageView() | |
private var indentationIconView = UIImageView() |
Fixed both of the issues! 📦 |
Fixes ##21818
To test:
Known issues:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: