Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings option to edit Gravatar and Site Icon #7404

Closed
elibud opened this issue Jun 20, 2017 · 8 comments
Closed

Add settings option to edit Gravatar and Site Icon #7404

elibud opened this issue Jun 20, 2017 · 8 comments

Comments

@elibud
Copy link
Contributor

elibud commented Jun 20, 2017

Currently tapping on your gravatar or your site icon is the only way to edit them. We want to add a more explicit option.

From @mattmiklic: a discrete option in profile settings / site settings for profile photo and site icon is probably the way to go.

cc: @tonyr59h

@tonyr59h
Copy link
Contributor

Some mockups from @mattmiklic:

@mindgraffiti
Copy link
Contributor

Reopening - site settings icon feature not yet implemented. (Me > My Profile photo feature is done.)

@mindgraffiti mindgraffiti reopened this Mar 15, 2018
@stale
Copy link

stale bot commented Mar 15, 2019

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

@stale stale bot added the [Status] Stale label Mar 15, 2019
@mindgraffiti mindgraffiti removed their assignment Mar 15, 2019
@stale stale bot removed the [Status] Stale label Mar 15, 2019
@designsimply
Copy link
Contributor

Tested with WP Internal 12.0.0.20190320 on iPhone 6S iOS 12.1.4 and found that Site Icon is still missing from the top of the Settings screen as indicated in the designs provided.

IMG_2172

WordPress.com Free, `madefortesting190318.wordpress.com`

However, I did noticed that I could change the Site Icon via the top of the Site Switcher screen on a WordPress.com or Jetpack site.

IMG_2173

WordPress.com Free, `madefortesting190318.wordpress.com`

I couldn't change the Site Icon from the top of the Site Switcher screen for a self-hosted site though.

IMG_2171

Self-hosted WordPress 5.1.1, `tasteless-petrel.jurassic.ninja`

@stale
Copy link

stale bot commented Mar 21, 2020

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

@designsimply
Copy link
Contributor

During the Information Architecture project, the site icon was added to the My Site (blog details) screen very prominently at the top. See designs at #13373.

(internal reference/master thread: pauD4L-8W-p2)

Current screenshots for reference:

My Site Site Settings
IMG_3829 IMG_3830

@mattmiklic I think the "Change Site Icon" option on the My Site screen is good enough and we don't also need to add it to the Site Settings screen. If you agree, could you close this issue with a note?

@stale
Copy link

stale bot commented May 2, 2022

This issue has been marked as stale because:

  • It has been inactive for the past year.
  • It isn't in a project or a milestone.
  • It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

@kean
Copy link
Contributor

kean commented Dec 20, 2024

This is now taken care of by the Gravatar framework.

@kean kean closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants