Support standard bullet styles #1409
Conversation
similar to web browsers, draw different bullets at different levels
commit 4d0522d Merge: 2b54f87 59d5090 Author: Gio Lodi <[email protected]> Date: Thu Mar 9 12:08:36 2023 +1100 Point `bash-cache` plugin to new `a8c-ci-toolkit` location (wordpress-mobile#1367) commit 59d5090 Author: Gio Lodi <[email protected]> Date: Mon Mar 6 21:10:15 2023 +1100 Remove unused YAML anchor and fix indentation in pipeline commit e0526bf Author: Gio Lodi <[email protected]> Date: Mon Mar 6 21:09:53 2023 +1100 Point `bash-cache` plugin to new `a8c-ci-toolkit` location While I was at it, I also updated the version to the latest, 2.13.0. This was done via: ``` find . -type f -name "*.yml" -exec sed -i '' 's/automattic\/bash-cache#[0-9.]\{1,\}/automattic\/a8c-ci-toolkit#2.13.0/g' {} + ``` commit 2b54f87 Merge: b7d8a70 d18d0a8 Author: Gio Lodi <[email protected]> Date: Thu Oct 20 16:59:18 2022 +1100 Add `CHANGELOG.md` (wordpress-mobile#1365) commit d18d0a8 Author: Gio Lodi <[email protected]> Date: Thu Oct 20 15:18:16 2022 +1100 Update `PULL_REQUEST_TEMPLATE.md` with note about `CHANGELOG.md` commit 2c73ef5 Author: Gio Lodi <[email protected]> Date: Thu Oct 20 14:32:38 2022 +1100 Add changelog entry about changelog itself commit 212ce2f Author: Gio Lodi <[email protected]> Date: Thu Oct 20 14:15:12 2022 +1100 Update `CHANGELOG.md` with new format commit b7d8a70 Merge: 91cf065 40afa55 Author: Gio Lodi <[email protected]> Date: Tue Oct 4 10:29:42 2022 +1100 Tools upgrade: Ruby 2.7.4, bash-cache 2.8.0 (wordpress-mobile#1363) commit 40afa55 Author: Gio Lodi <[email protected]> Date: Mon Oct 3 20:00:33 2022 +1100 Use `bash-cache` Buildkite plugin version 2.8.0 This version includes a fix that removes the need to run `gem install bundler` before each step. commit bd8840a Author: Gio Lodi <[email protected]> Date: Mon Oct 3 19:59:52 2022 +1100 Use Ruby version 2.7.4 commit 91cf065 Merge: 9d8d9b8 1ce621c Author: Diego Rey Mendez <[email protected]> Date: Wed Aug 10 15:07:41 2022 +0200 Merge pull request wordpress-mobile#1353 from cbess/expose-indentation-actions Expose indentation operations commit 9d8d9b8 Merge: b16c763 7eb60c7 Author: Tony Li <[email protected]> Date: Mon Jul 25 11:11:13 2022 +1200 Merge pull request wordpress-mobile#1359 from wordpress-mobile/remove/circle-ci Remove CircleCI commit 7eb60c7 Author: Jeremy Massel <[email protected]> Date: Fri Jul 22 23:23:27 2022 -0600 Trigger Build commit f91511e Author: Jeremy Massel <[email protected]> Date: Thu Jul 21 23:03:28 2022 -0600 Remove CircleCI commit 1ce621c Author: C. Bess <[email protected]> Date: Sat Mar 26 12:31:51 2022 -0500 cleanup whitespace commit ed55d4a Author: C. Bess <[email protected]> Date: Sat Mar 26 12:31:03 2022 -0500 cleanup whitespace commit 4561534 Author: C. Bess <[email protected]> Date: Sat Mar 26 12:01:30 2022 -0500 expose indentation operations - make increase/decrease indentation actions visible - cleanup code
- support indent style option
- support html-style order list, using alphabets and roman numerals - cleanup code
|
@twstokes it should be ready now :) |
cbess
changed the title
|
@twstokes any updates? |
There was a problem hiding this comment.
@cbess thanks for your work on this.
The only part I'm unsure of is ordered lists:
Similar to web browsers, draw different bullets at different levels.
The HTML spec supports different bullet styles as you mentioned for ordered lists, but in my testing browsers are rendering what Aztec is already doing by default.
I tested Chrome and Safari with:
<ol>
<li>One</li>
<ol>
<li>Two</li>
<ol>
<li>Three</li>
</ol>
</ol>
</ol>
And it renders:
This is also reflected in the MDN docs. Lastly, I get the same behavior in the iOS Notes app for ordered list nesting. I think in order to fully support ordered list styles we'd need to let the user choose them and have the appropriate HTML markup reflect the choice. If I'm misunderstanding something please let me know.
For unordered lists I think your changes work well in that they vary the bullets styles, which seems to be standard behavior. 👍
|
@twstokes You're welcome! I appreciate this library, thanks for maintaining it! You make a fair point about the
I was really copying examples like CKEditor 😅 
With that being said, perhaps the style can be renamed to |
|
- use varied
|
Updated enum member and the doc string |
Reopening: #1354
Similar to web browsers, draw different bullets at different levels.
To test:
listIndentStyleto.standardCHANGELOG.mdif necessary.