Rename Hand output structure to Gesture#1130
Merged
Merged
Conversation
The Hand input stream returns a structure with place, open, fingers, and per-finger booleans. Naming the structure "Hand" too collided with the input stream's name in every locale (same emoji 🖐️ and, in many locales, the same text), which the locale verifier rejects as a global-name duplicate. Renaming the structure to "Gesture" (emoji ✋) keeps the stream's name available while giving the result type its own identity. - OutputTexts.ts, en-US.json: rename output.Hand → output.Gesture - src/output/Hand.ts: update locale.output.Gesture references and the shares.output.Gesture lookup in createHandStructure. - createDefaultShares.ts: rename OutputTypes.Hand → Gesture. - 25 other locales: locales-fix removed Hand, locales-translate filled in Gesture names and field translations. - ko-KR doc cleanup: Google Translate had wrapped @hand in backticks which broke the structure parser; dropped the cross-reference sentence in en-US and stripped the artifact from ko-KR. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handinput stream returns a structure withplace,open,fingers, and per-finger booleans. Naming the structureHandtoo collided with the stream's name in every locale (same🖐️emoji and, in many locales, the same text), which the locale verifier rejects as a global-name duplicate.Gesture(emoji✋) so the stream and result type have distinct identities. Stream usage is unchanged:Hand()still works; the returned value now has typeGesture.Changes
src/locale/OutputTexts.ts,src/locale/en-US.json: renameoutput.Hand→output.Gesture(new emoji✋).src/output/Hand.ts: updatelocale.output.Gesturereferences throughoutcreateHandType, plus theshares.output.Gesturelookup increateHandStructure.src/runtime/createDefaultShares.ts: renameOutputTypes.Hand→OutputTypes.Gesture.npm run locales-fix(removedHand, addedGestureplaceholder) andnpm run locales-translate(filled in machine translations for the structure's names and field names).@Handin backticks, which broke the structure parser. Dropped the cross-reference sentence in en-US and stripped the artifact from ko-KR.Test plan
🤖 Generated with Claude Code