Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Span ctors and DynArray Resize methods #135

Merged
merged 18 commits into from
Jul 16, 2024
Merged

Conversation

Mozz3d
Copy link
Contributor

@Mozz3d Mozz3d commented Jul 14, 2024

No description provided.

@Mozz3d Mozz3d changed the title Add Span.hpp Ctors Add Span ctors and DynArray Resize methods Jul 14, 2024
Copy link
Owner

@wopss wopss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have one remark, if others are fine with it then it is all good.

include/RED4ext/DynArray.hpp Outdated Show resolved Hide resolved
include/RED4ext/Span.hpp Outdated Show resolved Hide resolved
Mozz3d added 2 commits July 14, 2024 12:19
Add default Span.hpp constructor
Removed entry construction from Resize() as it isn't necessary given its use cases
include/RED4ext/Span.hpp Outdated Show resolved Hide resolved
Mozz3d added 2 commits July 14, 2024 12:29
Remove handling of entry deconstruction in `Resize()` and rename it to `SetCapacity()` in DynArray.hpp
@Mozz3d Mozz3d requested a review from wopss July 14, 2024 17:07
include/RED4ext/Span.hpp Outdated Show resolved Hide resolved
@Mozz3d Mozz3d requested a review from wopss July 14, 2024 18:48
wopss
wopss previously approved these changes Jul 15, 2024
@Mozz3d Mozz3d requested a review from psiberx July 15, 2024 19:16
include/RED4ext/Span.hpp Outdated Show resolved Hide resolved
include/RED4ext/Span.hpp Outdated Show resolved Hide resolved
@psiberx psiberx merged commit 109d7fb into wopss:master Jul 16, 2024
9 checks passed
@Mozz3d Mozz3d deleted the patch-2 branch July 16, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants