Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix clang compat #130

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: fix clang compat #130

merged 1 commit into from
Jun 10, 2024

Conversation

jac3km4
Copy link
Contributor

@jac3km4 jac3km4 commented Jun 10, 2024 •
edited
Loading

fixes an issue with the code relying on msvc specific behavior in 2 places

@wopss wopss merged commit 1249843 into wopss:master Jun 10, 2024
9 checks passed
@wopss
Copy link
Owner

wopss commented Jun 10, 2024

Thanks!

@jac3km4 jac3km4 deleted the clang-compat branch June 10, 2024 18:06
wbourne0 added a commit to wbourne0/RED4ext.SDK that referenced this pull request Sep 5, 2024
@wbourne0
fix DynArray.hpp for clang/linux compile
e5faeba 
DynArray.hpp references allocators but doesn't require the file.
Presumably this usually works due to msvc behavior, but with clang
it fails.  Related: wopss#130
wbourne0 added a commit to wbourne0/RED4ext.SDK that referenced this pull request Sep 5, 2024
@wbourne0
fix DynArray.hpp for clang/linux compile
95e5c70 
DynArray.hpp references allocators but doesn't require the file.
Presumably this usually works due to msvc behavior, but with clang
it fails.  Related: wopss#130
@wbourne0 wbourne0 mentioned this pull request Sep 5, 2024
Merged
wbourne0 added a commit to wbourne0/RED4ext.SDK that referenced this pull request Sep 5, 2024
@wbourne0
fix DynArray.hpp for clang/linux compile
7c4402a 
DynArray.hpp references allocators but doesn't require the file.
Presumably this usually works due to msvc behavior, but with clang
it fails.  Related: wopss#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wopss wopss wopss approved these changes

@psiberx psiberx psiberx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jac3km4 @wopss @psiberx