Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animation KeyFrame structs + decoded properties #122

Merged
merged 47 commits into from
May 28, 2024

Conversation

Mozz3d
Copy link
Contributor

@Mozz3d Mozz3d commented May 14, 2024

No description provided.

@Mozz3d Mozz3d marked this pull request as draft May 14, 2024 15:22
@Mozz3d Mozz3d marked this pull request as ready for review May 14, 2024 17:55
Copy link
Owner

@wopss wopss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have some change requests.

include/RED4ext/Scripting/Natives/AnimSet.hpp Outdated Show resolved Hide resolved
include/RED4ext/Scripting/Natives/AnimSet.hpp Outdated Show resolved Hide resolved
include/RED4ext/Scripting/Natives/AnimKeyFrames.hpp Outdated Show resolved Hide resolved
include/RED4ext/Scripting/Natives/AnimKeyFrames.hpp Outdated Show resolved Hide resolved
include/RED4ext/Scripting/Natives/AnimKeyFrames.hpp Outdated Show resolved Hide resolved
psiberx
psiberx previously approved these changes May 16, 2024
@wopss wopss self-requested a review May 16, 2024 18:03
wopss
wopss previously approved these changes May 16, 2024
@wopss
Copy link
Owner

wopss commented May 21, 2024

Clang-format workflow is failing, can you take a look at it?

@Mozz3d Mozz3d dismissed stale reviews from wopss and psiberx via 8dbd8bd May 26, 2024 23:32
wopss
wopss previously approved these changes May 27, 2024
@wopss wopss requested a review from psiberx May 28, 2024 07:52
@psiberx psiberx merged commit f180450 into wopss:master May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants