-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animation KeyFrame structs + decoded properties #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds decoded class that contains pointer and data state for animation buffers
wopss
requested changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have some change requests.
include/RED4ext/Scripting/Natives/AnimationBufferCompressed.hpp
Outdated
Show resolved
Hide resolved
include/RED4ext/Scripting/Natives/AnimationBufferCompressed.hpp
Outdated
Show resolved
Hide resolved
Remove clang-format comment Co-authored-by: Octavian Dima <[email protected]>
Remove clang-format comment Co-authored-by: Octavian Dima <[email protected]>
Remove clang-format comment Co-authored-by: Octavian Dima <[email protected]>
Remove clang-format comment Co-authored-by: Octavian Dima <[email protected]>
assert offsets Co-authored-by: Octavian Dima <[email protected]>
Co-authored-by: Octavian Dima <[email protected]>
psiberx
previously approved these changes
May 16, 2024
wopss
previously approved these changes
May 16, 2024
Clang-format workflow is failing, can you take a look at it? |
wopss
approved these changes
May 27, 2024
wopss
previously approved these changes
May 27, 2024
psiberx
requested changes
May 28, 2024
psiberx
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.