-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoded Rig.hpp properties #114
Conversation
Replaces the `unk40` placeholder and adds `boneParentIndexes` and `boneTransforms` properties at offsets 0x40 and 0x48 respectively. Which have been confirmed through testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR :)
This file will be overwritten when every time we dump the types. You can move it out of the "Generated" directory and it should be fine, like we did for others (https://github.com/WopsS/RED4ext.SDK/tree/master/include/RED4ext/Scripting/Natives).
I'm wondering, should it be defined here, without redscript declaration... Or better be in Codeware, as it already provides such kind of native extensions? |
It should be in SDK but not in Generated. |
Moves Rig.hpp to Natives path
I moved it to Natives, I hope that's alright! |
Look at how other files are handled.
Also you could add a comment for new fields that the size is the same as |
…cripting/Natives/Generated/anim/Rig.hpp
Is this better? I've never really used github for anything besides viewing code so you'll have to excuse me if it's a little messy. Trying my best to figure it out. |
|
Adjusted property names and decoded a couple previously unknown properties
A little late, but here are the requested changes along with some further decoded properties. |
You also have to update the |
Is that okay? Also thank you for helping me help this project :3 |
It should be placed at |
Let me know if I need to adjust anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! :D
Replaces the
unk40
placeholder and addsboneParentIndexes
andboneTransforms
properties at offsets 0x40 and 0x48 respectively. Which have been confirmed through testing.