[FE] 참여가 여러번 되는 문제 해결(#805) #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
chlwlstlf
reviewed
Dec 13, 2024
There was a problem hiding this comment.
다르!! 변경 사항 확인했습니다😊 (방 제목이랑 키워드 잘못 본 줄 ^^)
변경 전
KakaoTalk_20241213_163204842.mp4
변경 후
-CoReA.Code.Review.Area.-.Chrome.2024-12-13.16-40-01.mp4
disabled만 되니까 3G 환경에서 1초 동안은 방도 안 들어가지고 버튼도 막혀서 흐름이 어색한 것 같아요..!
Button 속성 중에 isLoading이라는 속성이 있는데 이거도 같이 사용하는 거 어떤가요~???
{isLoading ? <S.LoadingSpinner src={spinner} /> : children}
|
disabled 상태인 경우 추가적으로 스피너가 보이도록 기능을 추가해줬어요! |
chlwlstlf
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용
느린 와이파이 환경에서 참여버튼을 여러번 클릭한 경우 여러번 서버에 post 요청이 보내져 중복참여되는 경우가 있었는데 tanstack query의 isPending 상태값을 이용하여 중복된 요청을 보내지 못하도록 해결
Screen.Recording.2024-12-10.at.6.08.56.PM.mov