[FE] 검색 기능 구현(#730) #741
Merged
[FE] 검색 기능 구현(#730) #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
chlwlstlf
approved these changes
Nov 7, 2024
Comment on lines
3
to
19
| export const SearchBarContainer = styled.div` | ||
| position: relative; | ||
| width: 100%; | ||
| height: 100%; | ||
| height: 40px; | ||
| `; | ||
|
|
||
| export const SearchBar = styled.input` | ||
| width: 100%; | ||
| height: 100%; | ||
| padding: 0.6rem 3rem 0.6rem 0.6rem; | ||
|
|
||
| font: ${({ theme }) => theme.TEXT.small}; | ||
|
|
||
| border: 1px solid ${({ theme }) => theme.COLOR.grey1}; | ||
| border-radius: 6px; | ||
| `; |
There was a problem hiding this comment.
이 부분이 padding과 height 말고는 Input 컴포넌트와 굉장히 유사하더라고요! 사실 height는 없어도 되는 속성이라 padding-right: 3rem만 추가면 Input 컴포넌트를 그대로 써도 괜찮을 것 같다고 생각합니다!
outline-color: ${({ theme }) => theme.COLOR.black};를 추가하면 focus 시 outline이 검정색으로 나온답니다😁
Comment on lines
+79
to
+89
| {searchedRooms.length === 0 ? ( | ||
| <RoomList | ||
| roomList={roomList} | ||
| hasNextPage={hasNextPage} | ||
| onLoadMore={onLoadMore} | ||
| isFetchingNextPage={isFetchingNextPage} | ||
| roomType={roomType} | ||
| /> | ||
| ) : ( | ||
| <RoomList roomList={searchedRooms} isFetchingNextPage={isLoading} roomType={roomType} /> | ||
| )} |
There was a problem hiding this comment.
검색 결과가 없을 때도 처리를 해주었네요! 저도 원래 데이터를 그대로 보여주는 게 좋다고 생각합니다👍
00kang
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용
384057044-d9e720e8-9e9e-470b-9945-85eff0e8e8f3.mov