Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 충분한 인원이 모집되지 않아 방을 자동 close할 때 처리(#550) #558

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 11, 2024

📓 스토리북 링크

바로가기

📌 관련 이슈

✨ PR 세부 내용

  • roomStauts에 FAIL이라는 매칭 실패 상태를 추가하여 작업했습니다.
    (원래 의도한 로직으로는 동작하지 않아서 추후 변경될 것 같아요)
  • 모킹데이터로 확인해봤어요.
메인 상세

@github-actions github-actions bot added FE 프론트 개발 관련 작업 기능 기능 구현 작업 labels Oct 11, 2024
@00kang 00kang self-assigned this Oct 11, 2024
Copy link
Contributor

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

방 참여 실패 시 보여주는 컴포넌트 좋네요!

참여 실패의 세분화는 나중에 고려해도 좋을거 같네요!

Copy link
Contributor

@chlwlstlf chlwlstlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 배겐드도 로직 잘 완성되었음 좋겠네요😎

Comment on lines +67 to +70
<S.ImgWithError>
<img src={defaultCharacter} alt="참여 중인 방이 아닙니다." />
<p>참여 중인 방이 아닙니다.</p>
</S.ParticipatedSection>
</S.ImgWithError>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 네이밍 좋은 것 같아요👍

Comment on lines +49 to +54
case "FAIL":
return css`
color: ${theme.COLOR.white};
background-color: ${theme.COLOR.error};
border: 1px solid ${theme.COLOR.error};
`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error 컬러도 잘 쓰이고 있네요ㅋㅋㅋㅋ

@chlwlstlf chlwlstlf merged commit 7b91a8c into develop Oct 11, 2024
2 checks passed
@chlwlstlf chlwlstlf deleted the feat/#550 branch October 11, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE 프론트 개발 관련 작업 기능 기능 구현 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FE] 충분한 인원이 모집되지 않아 방을 자동 close할 때 처리
3 participants