-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 충분한 인원이 모집되지 않아 방을 자동 close할 때 처리(#550) #558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
방 참여 실패 시 보여주는 컴포넌트 좋네요!
참여 실패의 세분화는 나중에 고려해도 좋을거 같네요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~ 배겐드도 로직 잘 완성되었음 좋겠네요😎
<S.ImgWithError> | ||
<img src={defaultCharacter} alt="참여 중인 방이 아닙니다." /> | ||
<p>참여 중인 방이 아닙니다.</p> | ||
</S.ParticipatedSection> | ||
</S.ImgWithError> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 네이밍 좋은 것 같아요👍
case "FAIL": | ||
return css` | ||
color: ${theme.COLOR.white}; | ||
background-color: ${theme.COLOR.error}; | ||
border: 1px solid ${theme.COLOR.error}; | ||
`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error 컬러도 잘 쓰이고 있네요ㅋㅋㅋㅋ
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용
FAIL
이라는 매칭 실패 상태를 추가하여 작업했습니다.(원래 의도한 로직으로는 동작하지 않아서 추후 변경될 것 같아요)