Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] 서비스 메인 배너 디자인 수정(#538) #549

Merged
merged 3 commits into from
Oct 11, 2024
Merged

[FE] 서비스 메인 배너 디자인 수정(#538) #549

merged 3 commits into from
Oct 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 10, 2024 •
edited by 00kang
Loading

📓 스토리북 링크

바로가기

📌 관련 이슈

✨ PR 세부 내용

  • 랜딩 페이지의 디자인에 따라 서비스의 배너 디자인이 수정되면 좋겠다는 피드백이 있어 작업했어요.
  • 다같이 디자인 선택한 거라서(너무 감사🙇‍♂️) 코드리뷰에서 신경써야 할 부분은 없는 것 같아요!
  • 태블릿도 고려하여 반응형 디자인 작업 완료했어요
before
after

@github-actions github-actions bot added FE 프론트 개발 관련 작업 디자인 디자인 관련 작업 labels Oct 10, 2024
@github-actions github-actions bot requested review from chlwlstlf and pp449 October 10, 2024 12:09
chlwlstlf
chlwlstlf approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@chlwlstlf chlwlstlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배너 바뀌면서 필요없는 코드 많아졌는데 다 찾아서 제거해주셨네요!! 역시 꼼꼼함👍👍👍💯💯

pp449
pp449 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@pp449 pp449 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배너가 드디어 바껴서 좋네용

퍼즐 이미지가 젤 맘에 드는거 같아용 ㅎㅎㅎ

@pp449 pp449 merged commit cfff6c6 into develop Oct 11, 2024
3 checks passed
@pp449 pp449 deleted the design/#538 branch October 11, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlwlstlf chlwlstlf chlwlstlf approved these changes

@pp449 pp449 pp449 approved these changes

Assignees

@00kang 00kang

Labels
FE 프론트 개발 관련 작업 디자인 디자인 관련 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FE] 서비스 메인 배너 디자인 수정
3 participants
@chlwlstlf @pp449 @00kang