fix: 피드백 모달에서 수정 시 이전 값에서 전체 초기화가 아니라 feedbackKeywords만 초기화

woowacourse-teams · Aug 13, 2024 · b8dae43 · b8dae43
1 parent b107c8a
commit b8dae43
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/frontend/src/hooks/feedback/useRevieweeFeedbackForm.ts b/frontend/src/hooks/feedback/useRevieweeFeedbackForm.ts
@@ -33,7 +33,7 @@ export const useRevieweeFeedbackForm = (
     if (modalType === "create") {
       setFormState({ ...initialFormState, receiverId });
     } else if (feedbackData) {
-      setFormState(feedbackData);
+      setFormState({ ...feedbackData, receiverId });
     }
   }, [modalType, feedbackData, receiverId]);
 
@@ -42,12 +42,13 @@ export const useRevieweeFeedbackForm = (
     value: RevieweeFeedbackData[keyof RevieweeFeedbackData],
   ) => {
     if (modalType === "view") return;
+
     if (key === "evaluationPoint") {
-      setFormState({
-        ...initialFormState,
-        receiverId: formState.receiverId,
+      setFormState((prevState) => ({
+        ...prevState,
         evaluationPoint: value as number,
-      });
+        feedbackKeywords: [],
+      }));
     } else {
       setFormState((prevState) => ({ ...prevState, [key]: value }));
     }

diff --git a/frontend/src/hooks/feedback/useReviewerFeedbackForm.ts b/frontend/src/hooks/feedback/useReviewerFeedbackForm.ts
@@ -32,7 +32,7 @@ export const useReviewerFeedbackForm = (
     if (modalType === "create") {
       setFormState({ ...initialFormState, receiverId });
     } else if (feedbackData) {
-      setFormState(feedbackData);
+      setFormState({ ...feedbackData, receiverId, feedbackId: feedbackData.feedbackId });
     }
   }, [modalType, feedbackData, receiverId]);
 
@@ -41,12 +41,13 @@ export const useReviewerFeedbackForm = (
     value: ReviewerFeedbackData[keyof ReviewerFeedbackData],
   ) => {
     if (modalType === "view") return;
+
     if (key === "evaluationPoint") {
-      setFormState({
-        ...initialFormState,
-        receiverId: formState.receiverId,
+      setFormState((prevState) => ({
+        ...prevState,
         evaluationPoint: value as number,
-      });
+        feedbackKeywords: [],
+      }));
     } else {
       setFormState((prevState) => ({ ...prevState, [key]: value }));
     }