Skip to content

Commit

Permalink
refactor: CookieService 를 CookieProvider 로 수정
Browse files Browse the repository at this point in the history
  • Loading branch information
hjk0761 committed Jan 21, 2025
1 parent 5f0fff0 commit b615361
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package corea.auth.service;
package corea.auth.infrastructure;

import jakarta.servlet.http.Cookie;
import org.springframework.http.ResponseCookie;
Expand All @@ -8,7 +8,7 @@
import java.util.Optional;

@Service
public class CookieService {
public class CookieProvider {

public ResponseCookie createCookie(String name, String value, long maxAge) {
return ResponseCookie.from(name, value)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import corea.auth.annotation.RefreshToken;
import corea.auth.dto.TokenRefreshRequest;
import corea.auth.service.CookieService;
import corea.auth.infrastructure.CookieProvider;
import corea.exception.CoreaException;
import corea.exception.ExceptionType;
import jakarta.servlet.http.Cookie;
Expand All @@ -21,7 +21,7 @@
@RequiredArgsConstructor
public class RefreshTokenArgumentResolver implements HandlerMethodArgumentResolver {

private final CookieService cookieService;
private final CookieProvider cookieProvider;

@Override
public boolean supportsParameter(MethodParameter parameter) {
Expand All @@ -36,7 +36,7 @@ public TokenRefreshRequest resolveArgument(MethodParameter parameter, ModelAndVi
if (cookies == null) {
throw new CoreaException(ExceptionType.COOKIE_NOT_EXIST);
}
return new TokenRefreshRequest(cookieService.getCookieValue(cookies, REFRESH_COOKIE)
return new TokenRefreshRequest(cookieProvider.getCookieValue(cookies, REFRESH_COOKIE)
.orElseThrow(() -> new CoreaException(ExceptionType.COOKIE_NOT_EXIST)));
}
}
5 changes: 3 additions & 2 deletions backend/src/main/java/corea/auth/service/LoginService.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import corea.auth.domain.LoginInfo;
import corea.auth.domain.TokenInfo;
import corea.auth.dto.GithubUserInfo;
import corea.auth.infrastructure.CookieProvider;
import corea.auth.repository.LoginInfoRepository;
import corea.exception.CoreaException;
import corea.member.domain.Member;
Expand All @@ -28,7 +29,7 @@ public class LoginService {
private final MemberRepository memberRepository;
private final TokenService tokenService;
private final LogoutService logoutService;
private final CookieService cookieService;
private final CookieProvider cookieProvider;

@Transactional
public TokenInfo login(GithubUserInfo userInfo) {
Expand Down Expand Up @@ -57,7 +58,7 @@ private ResponseCookie extendAuthorization(Member member) {
loginInfo -> loginInfoRepository.save(loginInfo.changeRefreshToken(refreshToken)),
() -> loginInfoRepository.save(new LoginInfo(member, refreshToken))
);
return cookieService.createCookie(REFRESH_COOKIE, refreshToken, COOKIE_EXPIRATION);
return cookieProvider.createCookie(REFRESH_COOKIE, refreshToken, COOKIE_EXPIRATION);
}

@Transactional
Expand Down

0 comments on commit b615361

Please sign in to comment.