[BE] fix: 학교 검색 시 발생하는 NPE 수정 (#895) #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 학교 식별자 목록으로 최근 축제 시작일 받아오는 클래스 이름 변경 - SchoolSearchUpcomingFestivalV1QueryService -> SchoolUpcomingFestivalStartDateV1QueryService
Test Results200 files 200 suites 24s ⏱️ Results for commit 69170c4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
✨ PR 세부 내용
학교 검색 시 발생하는 NPE를 수정했습니다.
원인은 #895 에 적어둔 것 처럼,
SchoolTotalSearchV1Response의 정팩메of()의 파라미터로 들어오는schoolSearchUpcomingFestivalV1Response값이 null이라 발생한 문제였습니다.따라서 기존
Map<Long, SchoolSearchUpcomingFestivalV1Response>를 반환하는 클래스인SchoolSearchUpcomingFestivalV1QueryService를Map<Long, LocalDate>를 반환하도록 하였고, 이름도SchoolUpcomingFestivalStartDateV1QueryService으로 변경했습니다.해당 클래스는 인터페이스인데, 추후 스프링 캐시가 적용된다면 굳이 인터페이스가 아니어도 될 것 같기도 하네요. 😂
클라이언트에 영향을 받는 문제이므로, 바로 머지 처리 하도록 하겠습니다!