Open
Conversation
- Prettier, ESlint: 컨벤션을 위해 스타일라이브러리 추가 - @woowacourse/mission-utils:유틸라이브러리 추가
- 유효성 검사: 범위, 갯수, 중복 여부 - sort : 오름차순으로 정렬 - includes: 특정 숫자가 포함되는지 확인
- 유효성 검사: 양수인지, 단위보다 큰지 - getLottoCount: 단위로 나눈 값을 반환
- 클래스 생성 테스트( 중복,범위)
- 보너스와 Lotto 객체를 프로퍼티로 가짐
- buyLottos: 랜덤한 숫자로 로또를 발행 - calculateResult: 통계를 계산함
- 파일을 오케스트레이션
- 의존성 주입
- 조건 늘어남에따라 복잡도 증가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
javascript-planetlotto-precourse
구현 할 목록
Model
Lotto : LottoNumber을 멤버로 가지는 모델
WinningLotto : LottoNumber과 Lotto 를 멤버로 가지는 모델
Money : 돈에 관한 모델
Rank : 등수 판별을 해주는 모델
LottoMachine : 로또를 발행 해주는 모델
기능
Lotto
Lotto Validaotor
LottoMachine
Money
Money Validator
Rank
LottoService
추가로 구현할 기능 목록
refactoring
expansion