Add vscode tailwind extensions & prettier tailwind linter, sort tailwind classes #4622
Conversation
|
Can we add linting as well then? Not everybody uses VSCode. |
pat-s
changed the title
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-4622.surge.sh |
.gitpod.yml
Outdated
| @@ -117,4 +117,6 @@ vscode: | |||
| - 'redhat.vscode-yaml' | |||
| - 'davidanson.vscode-markdownlint' | |||
| - 'streetsidesoftware.code-spell-checker' | |||
| - 'dejmedus.tailwind-sorter' | |||
There was a problem hiding this comment.
Seems to be doing the same as the prettier sorting?
There was a problem hiding this comment.
Yes, that's the idea?
There was a problem hiding this comment.
I am auto formatting with prettier on save which would now already sort the classes. Isn't using that plugin redundant?
There was a problem hiding this comment.
Yeah they might be indeed doing the same. The vscode one can use custom sorting but if we don't need that, we can stick with the prettier plugin.
I started with tailwind-sorter and didn't notice that the prettier plugin is then doing the same work. But it is better as it can be used with linting.
.prettierrc.json
Outdated
| @@ -4,5 +4,6 @@ | |||
| "singleQuote": true, | |||
| "printWidth": 120, | |||
| "tabWidth": 2, | |||
| "endOfLine": "lf" | |||
| "endOfLine": "lf", | |||
| "plugins": ["prettier-plugin-tailwindcss"] | |||
There was a problem hiding this comment.
Do we have to add this to the top-level config? There's no tailwind in there, only in web
There was a problem hiding this comment.
web/ and docs/ refer to the top-level config currently. See also #4628
Maybe it can be done in a different way, then one does not need to install this in their global npm package stack.
There was a problem hiding this comment.
Ah forget what I said, I think your proposed change should be just fine.
Co-authored-by: Anbraten <[email protected]>
These are the ones that cause the auto-sorting in all my recent PRs. If we would all use these (and sort all classes once), we'd have a predictable and consistent order of tailwind classes.