Skip to content

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Oct 23, 2025

Part of WOOMOB-1240

Description

This PR adds changes needed for filtering team members for bookings. Changes include:

  • Integrates the team member syncing in BookingsRemote, BookingStore, and BookingAction.
  • Creates a generic solution for syncable list selector. We'll need to reuse the solution for Service/Event filter in a subsequent PR.
  • Implements list selector for team members including syncing, pagination, and selection.

Apologies for the large number of changes. I should have separated the integration of the team member syncing in a separate PR but I wanted to unify all logic in one PR.

Testing steps

  • Log in to a CIAB store with existing bookings.
  • Navigate to Bookings tab > All > Filter.
  • Select Team member and confirm that the member list is loaded successfully.
  • Select any option and confirm that the list is dismissed, and the selected member name is displayed on the Filter screen.

Testing information

  • Tested functionalities with simulator iPhone 17.
  • Added unit tests for team member syncing in the Networking and Yosemite layers.

Screenshots

Simulator.Screen.Recording.-.iPhone.17.-.2025-10-24.at.10.25.10.mov

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.6 milestone Oct 23, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Oct 23, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 23, 2025

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 23, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16271-8cdd87d
Version23.5
Bundle IDcom.automattic.alpha.woocommerce
Commit8cdd87d
Installation URL5k79dj9b4bkbg
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Base automatically changed from woomob-1240-ui-booking-filters to trunk October 23, 2025 10:16
@itsmeichigo itsmeichigo marked this pull request as ready for review October 24, 2025 05:53
@RafaelKayumov RafaelKayumov self-assigned this Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants