Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Oct 22, 2025

Description

This PR enables POS Surveys in release builds.

Testing information

Testing one of the cases below is enough to assure the feature is enabled in release:

  1. Switch the build configuration to release.
  2. On a physical device, with notifications turned on, and in a US/UK store:
  3. Update POSNotificationScheduler.timeIntervalInSeconds to something like 5 seconds
  4. In AppCoordinator.schedulePOSSurveyNotificationIfNeeded add the following bit if needed to clear any persisted state from previous tests
private extension AppCoordinator {
    func schedulePOSSurveyNotificationIfNeeded() {
+        Task { @MainActor in
+          let action = AppSettingsAction.resetPOSSurveyNotificationScheduled { _ in }
+          stores.dispatch(action)
+        }
        Task { @MainActor in
            await POSNotificationScheduler(stores: stores).scheduleLocalNotificationIfEligible(for: .currentMerchant)
        }
    }
}
  1. Case 1 - Potential merchant case: Navigate to Orders > create an order > observe the survey notification appearing. Creating a second order should not show the notification again.
  2. Case 2 - Current merchant case: Visit POS once, restart the app, the notification should appear shortly.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Oct 22, 2025
@iamgabrielma iamgabrielma added this to the 23.6 milestone Oct 22, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review October 22, 2025 03:30
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16267-d9c37df
Version23.5
Bundle IDcom.automattic.alpha.woocommerce
Commitd9c37df
Installation URL13e5ltaodlnv8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma iamgabrielma requested a review from staskus October 22, 2025 03:43
Base automatically changed from task/WOOMOB-1528-update-current-merchant-trigger to trunk October 22, 2025 07:50
@iamgabrielma
Copy link
Contributor Author

@staskus no need to review this one from now, let's keep the feature flag on until we have final decision on the surveys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants