-
Notifications
You must be signed in to change notification settings - Fork 133
Merge release/23.3 into trunk #14683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
Project dependencies changeslist! Upgraded Dependencies
com.squareup.okhttp3:okhttp-tls:5.1.0, (changed from 4.12.0) tree-\--- project :libs:cardreader
- \--- com.stripe:stripeterminal-taptopay:4.6.0
- +--- com.squareup.okhttp3:okhttp-tls:4.12.0
- | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.1.0 (*)
- | +--- com.squareup.okio:okio:3.6.0 -> 3.15.0 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
- \--- com.stripe:stripeterminal-internal-common:4.6.0
- \--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
++--- project :libs:fluxc
+ \--- com.squareup.okhttp3:okhttp-tls:5.1.0
+ +--- com.squareup.okhttp3:okhttp:5.1.0 (*)
+ +--- com.squareup.okio:okio:3.15.0 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib:2.2.0 (*)
+\--- project :libs:cardreader
+ \--- com.stripe:stripeterminal-taptopay:4.6.0
+ +--- com.squareup.okhttp3:okhttp-tls:4.12.0 -> 5.1.0 (*)
+ \--- com.stripe:stripeterminal-internal-common:4.6.0
+ \--- com.squareup.okhttp3:okhttp-tls:4.12.0 -> 5.1.0 (*) |
Project manifest changes for WooCommerceThe following changes in the --- ./build/reports/diff_manifest/WooCommerce/vanillaRelease/base_manifest.txt 2025-10-02 15:28:44.249622163 +0000
+++ ./build/reports/diff_manifest/WooCommerce/vanillaRelease/head_manifest.txt 2025-10-02 15:29:15.479756916 +0000
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.woocommerce.android"
- android:versionCode="693"
- android:versionName="23.3-rc-1" >
+ android:versionCode="694"
+ android:versionName="23.3-rc-2" >
<uses-sdk
android:minSdkVersion="26" Go to https://buildkite.com/automattic/woocommerce-android/builds/32433/canvas?sid=0199a586-53e3-4770-b690-8d28151c796e, click on the |
Project manifest changes for WooCommerce-WearThe following changes in the --- ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/base_manifest.txt 2025-10-02 15:29:31.309824134 +0000
+++ ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/head_manifest.txt 2025-10-02 15:29:44.299878677 +0000
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.woocommerce.android"
- android:versionCode="50693"
- android:versionName="23.3-rc-1w" >
+ android:versionCode="50694"
+ android:versionName="23.3-rc-2w" >
<uses-sdk
android:minSdkVersion="26" Go to https://buildkite.com/automattic/woocommerce-android/builds/32433/canvas?sid=0199a586-53e3-4770-b690-8d28151c796e, click on the |
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14683 +/- ##
============================================
- Coverage 38.50% 38.50% -0.01%
+ Complexity 9775 9774 -1
============================================
Files 2066 2066
Lines 115514 115514
Branches 15390 15390
============================================
- Hits 44477 44476 -1
Misses 66906 66906
- Partials 4131 4132 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging
release/23.3
intotrunk
.Via intermediate branch
merge/release-23.3-into-trunk
, to help fix conflicts if any: