Skip to content

erc721 self serve contracts#2

Open
wolfy-nft wants to merge 35 commits intomainfrom
adam/feat/selfserve
Open

erc721 self serve contracts#2
wolfy-nft wants to merge 35 commits intomainfrom
adam/feat/selfserve

Conversation

@wolfy-nft
Copy link
Owner

@wolfy-nft wolfy-nft commented Dec 6, 2024

Overview

  • ERC721ACloneable: a copy of ERC721A with Initializable
  • ERC721AQueryableCloneable: a copy of ERC721AQueryable, extends ERC721ACloneable
  • ERC721MagicDropMetadataCloneable: storage for contract metadata
  • ERC721MagicDropCloneable: biz logic (public/allowlist stages), protocol fees, extends ERC721MagicDropMetadataCloneable
  • ERC721AConduitPreapprovedCloneable: provides immediate trading on the ME seaport conduit (no approval tx required)

Tests

28 new test cases added for ERC721MagicDropCloneable
Screenshot 2024-12-09 at 8 57 55 PM

21 new tests added for ERC721MagicDropMetadataCloneable
Screenshot 2024-12-09 at 9 12 13 PM

code coverage. both should be 100% but theres an lcov bug causing missing coverage on two lines
Screenshot 2024-12-18 at 1 12 00 PM

Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a direct copy of 721AQueryable with added Initialization

@wolfy-nft wolfy-nft changed the title asdf erc721 self serve Dec 10, 2024
@wolfy-nft wolfy-nft changed the title erc721 self serve erc721 self serve contracts Dec 10, 2024
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants