Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcsc-lite - usrmerge usr/sbin #44674

Merged
merged 4 commits into from
Mar 31, 2025
Merged

Conversation

smoser
Copy link
Member

@smoser smoser commented Mar 5, 2025

No description provided.

@a-crate
Copy link
Member

a-crate commented Mar 5, 2025

pcsc-lite needs /usr/sbin-merged eudev I think. From the last build failure in #44098:

failed to build package: unable to build guest: unable to generate image: installing apk packages: installing packages: installing eudev (ver:3.2.14-r5 arch:x86_64): unable to install files for pkg eudev: unable to install symlink from usr/sbin/udevadm -> /usr/bin/udevadm

*Added

@a-crate a-crate force-pushed the usrmerge-usrsbin/pcsc-lite branch 2 times, most recently from 22d77f3 to 2426e01 Compare March 5, 2025 17:31
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Mar 5, 2025
@a-crate
Copy link
Member

a-crate commented Mar 5, 2025

Built once at 22d77f3... which is identical to the latest changes that failed, unless I'm missing something. Flake?

@a-crate a-crate force-pushed the usrmerge-usrsbin/pcsc-lite branch from 2426e01 to 93998bb Compare March 5, 2025 22:56
@a-crate a-crate force-pushed the usrmerge-usrsbin/pcsc-lite branch from 93998bb to ee5c4ed Compare March 24, 2025 23:52
Copy link
Contributor

octo-sts bot commented Mar 24, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the error message, I'll provide a structured analysis and solution:

• Detected Error:

solving "merged-usrsbin" constraint: nothing provides "merged-usrsbin"

• Error Category: Dependency

• Failure Point:
Initial environment setup when resolving APK packages

• Root Cause Analysis:
The package depends on merged-usrsbin which is no longer available in Wolfi. This was likely renamed or deprecated as part of Wolfi's evolution to align with modern Linux filesystem hierarchy standards.

• Suggested Fix:
Remove the merged-usrsbin dependency from both the main package and subpackage sections:

package:
  dependencies:
    runtime:
      - wolfi-baselayout   # Remove merged-usrsbin line

subpackages:
  - name: ${{package.name}}-dev
    dependencies:
      runtime:
        - pcsc-lite
        - wolfi-baselayout   # Remove merged-usrsbin line

• Explanation:
The merged-usrsbin package was historically used to handle the /usr/sbin and /sbin directory merge, but this is now handled directly by wolfi-baselayout. Modern Linux distributions, including Wolfi, follow the usr-merge standard where these directories are consolidated under /usr.

• Additional Notes:

  • The -Dsbindir=/usr/bin meson option in your configuration already handles the correct binary placement
  • wolfi-baselayout provides the necessary directory structure
  • This change aligns with modern filesystem hierarchy standards

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Mar 24, 2025
@a-crate a-crate force-pushed the usrmerge-usrsbin/pcsc-lite branch from ee5c4ed to 1722132 Compare March 25, 2025 16:32
@smoser smoser force-pushed the usrmerge-usrsbin/pcsc-lite branch from 1722132 to 051c90a Compare March 31, 2025 14:58
@smoser smoser merged commit df900d0 into wolfi-dev:main Mar 31, 2025
15 checks passed
MickeyPvX pushed a commit to MickeyPvX/wolfi-dev-os that referenced this pull request Apr 1, 2025
Signed-off-by: Amelia Crate <[email protected]>
Co-authored-by: Amelia Crate <[email protected]>
Co-authored-by: Dimitri John Ledkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants