-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: Use more generic march for rosetta compatibiity #44644
Conversation
See: wolfi-dev#38076 Related: chainguard-dev/customer-issues/2094 Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation. To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify: e.g. /ai-verify partially helpful but I also added bash to the build environment Gen AI suggestions to solve the build error: • Detected Error: "checking whether wchar_t is usable... no" • Error Category: Build Configuration • Failure Point: Configure step during Python build • Root Cause Analysis: The build is failing because the system is unable to properly use wchar_t, which is critical for Python's Unicode support. This typically indicates a mismatch between compiler settings and system libraries. • Suggested Fix:
- name: Configure
runs: |
# Add these environment variables before ./configure
export CFLAGS="${CFLAGS} -fwrapv -D_GNU_SOURCE"
export CPPFLAGS="${CPPFLAGS} -D_GNU_SOURCE" • Explanation:
• Additional Notes:
• References:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Test errors on 3.12 and 3.13 will investigate |
hmm locally as non-root I get
|
Test to see if failure on `Test file capabilities` needs this for setcap/getcap Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Add tee to debug getcap test failure Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Signed-off-by: Pris Nasrat <pris.nasrat@chainguard.dev>
Is there any additional testing we should do to make sure this isn't going to break anything (abi-checker maybe?) Will this noticeably regress performance for any customers? We may very well want to do this anyway of course - it would just be good to understand the trade-offs and do what we can to avoid other customer escalations. |
…i-dev#44644)" pyperformance on a gcloud VM noticed some seemingly significant regressions due to this. Let's roll it back until we can properly assess how to proceed. This reverts commit 0d66ee5. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
See: #38076
Related: chainguard-dev/customer-issues#2094
Signed-off-by: Pris Nasrat pris.nasrat@chainguard.dev