Skip to content

Usrmerge usrsbin 3 #44563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 31, 2025
Merged

Usrmerge usrsbin 3 #44563

merged 9 commits into from
Mar 31, 2025

Conversation

a-crate
Copy link
Member

@a-crate a-crate commented Mar 4, 2025

No description provided.

@a-crate a-crate mentioned this pull request Mar 4, 2025
@a-crate a-crate force-pushed the usrmerge-usrsbin-3 branch 2 times, most recently from 71b63a7 to d105811 Compare March 5, 2025 01:54
Copy link
Contributor

octo-sts bot commented Mar 5, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error:
"failed to build package: unable to build guest: unable to generate image: installing apk packages: installing packages: installing coreutils (ver:9.6-r0 arch:x86_64): unable to install files for pkg coreutils: unable to install symlink from usr/bin/env -> coreutils: symlink coreutils /tmp/melange-guest-4246341154/usr/bin/env: file exists"

• Error Category: Dependency/Configuration

• Failure Point:
Package installation step - specifically when trying to install coreutils package and create symlinks

• Root Cause Analysis:
The error occurs because there's a conflict with the /usr/bin/env symlink. This typically happens when multiple packages try to provide the same symlink, or when busybox is already providing this symlink.

• Suggested Fix:
Add build environment configuration to handle the symlink conflict:

environment:
  contents:
    packages:
      - busybox<~>
      # Move coreutils before busybox in the list
      - coreutils
      - busybox
      # rest of your packages...

• Explanation:
By ensuring coreutils is installed before busybox and explicitly marking busybox as replaceable (<~>), we allow coreutils to take precedence for the symlinks it provides. This resolves the conflict while maintaining necessary functionality.

• Additional Notes:

  • This is a common issue when dealing with base utilities that may have overlapping functionality
  • Both busybox and coreutils provide basic Unix utilities, and their symlinks can conflict
  • The order of package installation matters in this case

• References:

@octo-sts octo-sts bot added ai/skip-comment Stop AI from commenting on PR bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. labels Mar 5, 2025
@a-crate a-crate force-pushed the usrmerge-usrsbin-3 branch 3 times, most recently from ec3d25e to e3b2c90 Compare March 5, 2025 03:07
@smoser smoser force-pushed the usrmerge-usrsbin-3 branch from e3b2c90 to a9d47b3 Compare March 5, 2025 19:45
@zmarano zmarano force-pushed the usrmerge-usrsbin-3 branch from a9d47b3 to 2692faf Compare March 5, 2025 22:40
@a-crate a-crate force-pushed the usrmerge-usrsbin-3 branch 3 times, most recently from 4bb8fe1 to 8423f13 Compare March 24, 2025 23:27
justinvreeland
justinvreeland previously approved these changes Mar 24, 2025
@a-crate a-crate force-pushed the usrmerge-usrsbin-3 branch from 8423f13 to 1e33dae Compare March 25, 2025 15:55
@a-crate a-crate marked this pull request as ready for review March 31, 2025 16:00
@a-crate a-crate requested a review from a team as a code owner March 31, 2025 16:00
a-crate added 7 commits March 31, 2025 09:11
Signed-off-by: Amelia Crate <[email protected]>
Signed-off-by: Amelia Crate <[email protected]>
Signed-off-by: Amelia Crate <[email protected]>
Signed-off-by: Amelia Crate <[email protected]>
Signed-off-by: Amelia Crate <[email protected]>
Signed-off-by: Amelia Crate <[email protected]>
@a-crate a-crate self-assigned this Mar 31, 2025
@a-crate a-crate enabled auto-merge March 31, 2025 16:27
@a-crate a-crate merged commit 303bef8 into wolfi-dev:main Mar 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants